Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ko #9043

Merged
merged 5 commits into from Sep 5, 2023
Merged

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Aug 23, 2023

Fixes: #8948

Description

  • upgrade ko and moby/buildkit
  • Resolve conflicts:
  • clean up go.mod , some exclude clauses don't make sense anymore, as we're already on a later version.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #9043 (b01ca70) into main (290280e) will decrease coverage by 7.13%.
Report is 1021 commits behind head on main.
The diff coverage is 49.90%.

@@            Coverage Diff             @@
##             main    #9043      +/-   ##
==========================================
- Coverage   70.48%   63.35%   -7.13%     
==========================================
  Files         515      626     +111     
  Lines       23150    32109    +8959     
==========================================
+ Hits        16317    20344    +4027     
- Misses       5776    10223    +4447     
- Partials     1057     1542     +485     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 424 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cnbl "github.com/buildpacks/lifecycle/launch"
cnb "github.com/buildpacks/lifecycle/platform"
cnb "github.com/buildpacks/lifecycle/platform/files"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review August 24, 2023 17:59
@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner August 24, 2023 17:59
@ericzzzzzzz ericzzzzzzz requested review from maggieneterval and removed request for maggieneterval August 24, 2023 17:59
@ericzzzzzzz ericzzzzzzz added kokoro:force-run forces a kokoro re-run on a PR and removed kokoro:force-run forces a kokoro re-run on a PR labels Aug 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 24, 2023
@joeyslalom
Copy link

Thank you! As a user of ko with skaffold, this will help me update my project to Go 1.20 <3

pkg/skaffold/docker/image.go Outdated Show resolved Hide resolved
@ericzzzzzzz ericzzzzzzz merged commit bca77a4 into GoogleContainerTools:main Sep 5, 2023
14 checks passed
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Sep 13, 2023
* chore: upgrade moby/buildkit and ko

* chore: vendor deps

* chore: fix dep conflicts

* chore: use nil as default for container.stopOption

* use util for int pointer
ericzzzzzzz added a commit that referenced this pull request Sep 13, 2023
* chore: upgrade ko (#9043)

* chore: upgrade moby/buildkit and ko

* chore: vendor deps

* chore: fix dep conflicts

* chore: use nil as default for container.stopOption

* use util for int pointer

* chore: schema check target to release/v2.7

* chore: add origin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability of dependency "github.com/moby/buildkit"
4 participants