Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert element-library package to TypeScript #12558

Closed
barklund opened this issue Oct 28, 2022 · 0 comments · May be fixed by #13503
Closed

Convert element-library package to TypeScript #12558

barklund opened this issue Oct 28, 2022 · 0 comments · May be fixed by #13503
Labels
P3 Nice to have Package: Elements /packages/elements Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@barklund
Copy link
Contributor

When converting the individual elements to TypeScript, move the related element type definitions from the elements package to that folder as well.

Note that the ElementDefinition type might require a lot of work. The current generic version might not be the right one in the end.

This ticket is split from #12126, as this turned out to be a rather complex task.
@barklund barklund added P2 Should do soon Type: Infrastructure Changes impacting testing infrastructure or build tooling Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: Prometheus Package: Elements /packages/elements labels Oct 28, 2022
@barklund barklund self-assigned this Oct 28, 2022
@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels May 12, 2023
@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
@swissspidy swissspidy mentioned this issue Nov 22, 2023
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Nice to have Package: Elements /packages/elements Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert element-library to TypeScript GoogleForCreators/web-stories-wp
2 participants
@barklund @swissspidy