Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a text color or text style preset is broken with inline selection #1609

Closed
barklund opened this issue May 6, 2020 · 1 comment
Closed
Labels
Elements: Text P2 Should do soon Status: Not Implemented Issue/PR we will (likely) not implement Type: Bug Something isn't working

Comments

@barklund
Copy link
Contributor

barklund commented May 6, 2020

Bug Description

When in edit mode inside a text field with multiple colors in the given selection, adding a text color or text style preset does not work. Currently the click to add a preset is completely ignored.

Fixing this requires figuring out exactly what should happen in the different possible cases.

This is a known consequence of #1323.

Expected Behaviour

  • Expected behavior is unknown.

Steps to Reproduce

  1. Add a text field
  2. Enter edit mode
  3. Make some part of the text field green, another part blue
  4. Select everything in the text field
  5. Click the "+" icon under presets to add a new preset based off the current selection
  6. Observe that nothing happens

Screenshots


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@o-fernandez
Copy link
Contributor

I documented this and put it as WAI for now. We can revisit this and implement some other changes in the future if necessary, but for now, closing as not a priority.

@swissspidy swissspidy added the Status: Not Implemented Issue/PR we will (likely) not implement label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements: Text P2 Should do soon Status: Not Implemented Issue/PR we will (likely) not implement Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants