Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: Frame and display layer not in sync when zoomed #7638

Open
miina opened this issue May 21, 2021 · 2 comments
Open

RTL: Frame and display layer not in sync when zoomed #7638

miina opened this issue May 21, 2021 · 2 comments
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Canvas Group: Selection Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P3 Nice to have Type: Bug Something isn't working

Comments

@miina
Copy link
Contributor

miina commented May 21, 2021

Bug Description

The selection frame and the displayed element are not in sync. This can be seen especially well when setting the zoom level to 200%, however, some styling oddities can be noticed in the default zoom level, too.

Edit:
Additionally, horizontal scrolling while in Zoom only moves the frame layer but not the display layer.

Expected Behaviour

The display and frame layer should be in sync and look as expected in RTL mode.

Steps to Reproduce

  1. Set the mode to RTL
  2. Add an element, select it
  3. Set the zoom level to 200%
  4. See the display and frame difference
  5. Resize the window so that horizontal scrollbar would appear, too.
  6. Scroll horizontally -- see the frame moving but not the display.

Screenshots

Out of sync frame / display
Screenshot 2021-05-20 at 17 10 24

zoom

Incorrect selection styling (a bit shifted):
Screenshot 2021-05-21 at 12 21 17

Additional Context

From Morten:

Looks like the padding for the lack of scrollbar is added to the wrong side of the container in the display layer - the display layer does not have a scrollbar, but most still reserve the space to align the elmeents correctly with the frames layer.

  • Plugin Version:
  • WordPress Version:
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

@miina miina added Type: Bug Something isn't working Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). P2 Should do soon Group: Canvas Group: Selection Pod: Prometheus Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar labels May 21, 2021
@miina miina self-assigned this Jun 16, 2021
@miina
Copy link
Contributor Author

miina commented Jun 18, 2021

Edit: Expanding the scope of this issue since apparently there are more issues related to Zoom + layers.

  • Only Chrome has the original issue, Safari and Firefox work as expected, so the fix for the out of sync Moveable due to scrollbar should be for Chrome only.
  • Additionally, horizontal scrolling does not work as expected anywhere when zoomed in.

@miina miina removed their assignment Jun 18, 2021
@miina
Copy link
Contributor Author

miina commented Jun 18, 2021

@bmattb FYI it came out there were more issues with Zoom than originally thought, and I raised the points for this issue.

@miina miina assigned miina and unassigned miina Jul 2, 2021
@miina miina changed the title Frame and display layer not in sync when zoomed RTL: Frame and display layer not in sync when zoomed Jan 21, 2022
@miina miina added P3 Nice to have and removed P2 Should do soon labels Jan 21, 2022
@swissspidy swissspidy added P2 Should do soon and removed P3 Nice to have labels May 9, 2023
@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Canvas Group: Selection Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P3 Nice to have Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants