Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Editing Text as soon as Text Box is in Focus #830

Closed
jauyong opened this issue Mar 27, 2020 · 5 comments · Fixed by #1810
Closed

Enable Editing Text as soon as Text Box is in Focus #830

jauyong opened this issue Mar 27, 2020 · 5 comments · Fixed by #1810
Labels
Elements: Text P1 High priority, must do soon Type: Bug Something isn't working

Comments

@jauyong
Copy link

jauyong commented Mar 27, 2020

Bug Description

The default rules for selecting and editing text are not applied as specified in figma

When a user adds text, they see the hint within the text box (fine):
image
But when they click within, they have to manually delete or overwrite this tip ("Double-click..."). Should the tip automatically "clear" when user clicks within the field?

Note: This issue does not deal with automatically enabling edit-mode when a new text field is added. This is only about being able to type while text box is in focus to edit content.

Reported by Claudio on #576

Expected Behaviour

  1. You should be able to just start typing once the text box is in focus

Steps to Reproduce

Screenshots


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

Alphanumeric: Replace with new content

  1. Add a text field
  2. Unselect and reselect the text field using the mouse to make sure it has keyboard focus
  3. Type any alphanumeric character and observe text field going into edit mode with only the typed character (NB: this only supports a-z and 0-9)

Enter: Select content

  1. Add a text field
  2. Unselect and reselect the text field using the mouse to make sure it has keyboard focus
  3. Press enter and observe text field going into edit mode with all the currently present content selected and ready to be replaced by whatever is typed next. Also observe, that no actual newline is inserted despite pressing enter
@jauyong jauyong added P2 Should do soon Type: Enhancement New feature or improvement of an existing feature labels Apr 7, 2020
@jauyong jauyong changed the title Clear Text Box Helper Text Text Selection and Edit Rules Apr 14, 2020
@jauyong jauyong added P1 High priority, must do soon and removed P2 Should do soon labels Apr 14, 2020
@jauyong jauyong changed the title Text Selection and Edit Rules Enable Editing Text as soon as Text Box is in Focus Apr 24, 2020
@jauyong jauyong removed the Type: Enhancement New feature or improvement of an existing feature label Apr 24, 2020
@swissspidy
Copy link
Collaborator

Related: #1608

@csossi
Copy link

csossi commented Jun 3, 2020

tested in QA Environment PR#2183

re: Instructions above

Alphanumeric: Replace with new content

  1. Add a text field
  2. Make sure it is selected
  3. Type any alphanumeric character and observe text field going into edit mode with only the typed character (NB: this only supports a-z and 0-9)

Not working as described here. selected text element:
image.png

And when I began typing, it looked like this - just seeing a horizontal line:
image.png

@obetomuniz
Copy link
Contributor

Hey @csossi, could you check it again using the PR#1810 env? At least, that's was the env that I addressed this issue, not PR#2183. Let me know if you have any doubt 😄

@csossi
Copy link

csossi commented Jun 11, 2020

Verified in QA - thanks, @obetomuniz

@samitron7
Copy link

samitron7 commented Jun 15, 2020

Verified in UAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements: Text P1 High priority, must do soon Type: Bug Something isn't working
Projects
None yet
6 participants