Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated dependency #17

Open
opravil-jan opened this issue Jun 10, 2019 · 4 comments
Open

Deprecated dependency #17

opravil-jan opened this issue Jun 10, 2019 · 4 comments

Comments

@opravil-jan
Copy link

Hi Guys,

is it possible to update dependency graphql-subscriptions up to version 1.0.0?

Thanks

@Jonahss
Copy link

Jonahss commented Mar 20, 2021

I forked this repo and replaced pg-ipc with pg-listen
So now it will retry the connection to postgres.

Also update deps.

https://github.com/originlabs/graphql-postgres-subscriptions

Published to npm as @originlabs/graphql-postgres-subscriptions-retry

@cmidgley
Copy link

@Jonahss Thanks for sharing the repo! Since Issues are not available on your repo fork I thought I'd try to reach you here. I wanted to share that the github link on the NPM page goes to the original graphql-postgres-subscriptions github and not your @originlabs/graphql-postgres-subscriptions-retry github repo.

Also was wondering if you had any plans to add typescript definitions for it? If not, I make take a stab at it.

@Jonahss
Copy link

Jonahss commented Mar 24, 2021

Oh! I'm not used to issues not being enabled by default. Added them, thanks.

@cmidgley Typescript definitions would be very welcome!

I think you can use the type already defined for this class: https://github.com/apollographql/graphql-subscriptions/blob/master/src/pubsub-engine.ts

@Jonahss
Copy link

Jonahss commented Mar 31, 2021

@cmidgley I just published a new patch version, fixing a major bug where once one connection was killed, no new notifications came in 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants