Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Create better support for custom connections #110

Open
cshadek opened this issue Mar 13, 2023 · 2 comments
Open

Feature: Create better support for custom connections #110

cshadek opened this issue Mar 13, 2023 · 2 comments

Comments

@cshadek
Copy link
Contributor

cshadek commented Mar 13, 2023

There was discussion in #106 about enabling better support for custom connections and recent changes were made to make that easier to implement in #107, #108, and #109.

  1. Ideally it would be nice to have an easy way to declare connections with custom fields and edges with custom fields. I'm not exactly sure the best way to implement this, but it would be nice to have the customization and at the same time utilize the existing connection code, including slicing, etc.

@NeedleInAJayStack I know you mentioned you had begun to think about how this might be accomplished.

  1. In addition, maybe it makes sense to also think about the "connection of a protocol" issue where because Node needs to implement Encodable, it is currently not possible to have a connection of a Union or Interface. There is a fix, and that is to create a wrapper type, but that's obviously not the cleanest approach.

A possible solution to 2 was mentioned here:
#50 (comment)

@NeedleInAJayStack
Copy link
Member

Just put in a pull request that addresses item 1: #112

@cshadek
Copy link
Contributor Author

cshadek commented Mar 14, 2023

Well that was fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants