Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutations should run in SERIES not parallel #65

Open
cshadek opened this issue Jul 16, 2021 · 2 comments
Open

Mutations should run in SERIES not parallel #65

cshadek opened this issue Jul 16, 2021 · 2 comments
Labels

Comments

@cshadek
Copy link
Contributor

cshadek commented Jul 16, 2021

I'm running Graphiti 0.26.0 and noticed that Mutations seem to be running in parallel when they should be running in series.

A simple example would be:

mutation Test {
    addLike(input: {id: 1}) {
       ....
    }
    removeLike(input: {id: 1} ) {
       ....
    }
    addLike2: addLike(input: {id: 1} ) {
       ....
    }
}

Ideally this should run the top fields in order, per the spec, but it doesn't and it seems to run them in parallel, leading to potential race conditions and unintended results.

@cshadek
Copy link
Contributor Author

cshadek commented Jul 16, 2021

@paulofaria do you have suggestions on the best way to fix this?

@cshadek
Copy link
Contributor Author

cshadek commented Jul 16, 2021

This is the part of the spec that specifies that mutations should run in series.

http://spec.graphql.org/June2018/#sec-Mutation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants