Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 获取数组元素时候,未检测数组是否为空,导致越界访问 #2468

Open
lanfengc opened this issue Jan 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lanfengc
Copy link

在 src/main/java/emu/grasscutter/game/entity/EntityMonster.java 的第388行,
有这样一句代码:
var towerManager = getScene().getPlayers().get(0).getTowerManager();
当玩家在尘歌壶内下线时候,登陆游戏就会出错,导致无法登陆。

@lanfengc lanfengc added the bug Something isn't working label Jan 13, 2024
@lanfengc
Copy link
Author

修改方法:
把第388行和第389行的代码:
var towerManager = getScene().getPlayers().get(0).getTowerManager();
if (dungeonManager != null && dungeonManager.isTowerDungeon() && towerManager != null) {

改成:
var players = getScene().getPlayers();
if (dungeonManager != null && dungeonManager.isTowerDungeon() && players != null && !players.isEmpty()) {
var towerManager = players.get(0).getTowerManager();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant