Data Node Migration: remove unnecessary steps/big texts/unavailable paths #19312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gally47
changed the title
gally47
changed the title
|
Tested both in-place and remote reindexing from OS and checked that migration selection is skipped for Elasticsearch (without migration). Here are my comments:
|
moesterheld
previously requested changes
May 17, 2024
| </p> | ||
| <p> | ||
| Enable JWT authentication in <code>opensearch-security/config.yml</code> (section <code>jwt_auth_domain</code>, <code>http_enabled: true</code>, <code>transport_enabled: true</code>) | ||
| Add the signing key by converting the <code>GRAYLOG_PASSWORD_SECRET</code> to <code>base64</code> e.g. by doing <code>echo `"`The password secret you chose`"` | base64</code> and put it into the <code>signing_key</code> line | ||
| If you are running <code>ElasticSearch</code> as your search backend or want to selectively migrate data |
There was a problem hiding this comment.
Since we do not give the user a choice if he's running Elastic, we should maybe reword that here
todvora
approved these changes
May 21, 2024
bernd
dismissed
moesterheld’s stale review
Dismissing review because reviewer is absent. Requested by @gally47.
ousmaneo
pushed a commit
that referenced
this pull request
May 24, 2024
…aths (#19312) * remove unnecessary texts + rewording * changelog * remove Certificate provisioning overview step in in-place migration * remove Provision Data Node with certificates step from remote reindexing migration * remove unused MigrationStates * add guard for disabling in-place migration for ElasticSearch * add guard for disabling in-place migration for ElasticSearch * sort indices for remote reindexing * stop fetching CurrentMigrationStatus when error * clear interval and cleanup logs when error * RetryMigrateExistingData ConfirmDialog when no errors + reordered buttons position * add default elasticsearch_hosts and allowlist to state machine response * fix buttons order * Sort Next Steps * cleanup comments * MigrateExistingData set initial values elasticsearch_hosts and allowlist_hosts * filter migrationTypeOptions show only possible paths * skip migration selection page when not compatible * added JwtAuthenticationInfo * remove prefilled host/allowlist values * reword case ElasticSearch as search backend * remove unreachable steps * fix tests --------- Co-authored-by: Matthias Oesterheld <33032967+moesterheld@users.noreply.github.com> Co-authored-by: Matthias Oesterheld <matthias.oesterheld@graylog.com> Co-authored-by: Tomas Dvorak <tomas.dvorak@graylog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
Motivation and Context
fixes #19229
Types of changes
Checklist: