Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateTransform breaks world scaling if scaled down #100

Open
marfri opened this issue Apr 4, 2017 · 2 comments
Open

updateTransform breaks world scaling if scaled down #100

marfri opened this issue Apr 4, 2017 · 2 comments
Labels

Comments

@marfri
Copy link
Collaborator

marfri commented Apr 4, 2017

updateTransform (gown.js:7081) for GOWN.Control with resizeScaling set to true if scaled down scaleX and scaleY are always not 1, thus the resizeScaling gets applied every time until worldTransform.a and worldTransform.d are Infinity.

@marfri marfri added the bug label Apr 4, 2017
@FabianElsmer
Copy link
Collaborator

My suggested fix for this is only applying the inversion of the scaling when the world transform was actually updated. The transform of the DisplayObject contains an ID that is counted up whenever the world transform was recalculated. In Pixi v4 they changed when transforms are recalculated (only when the object was changed since the last calculation)

@FabianElsmer
Copy link
Collaborator

It would be cleaner if we could avoid that inversion alltogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants