Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pixi-layout and pixi-shapes back into GOWN.js #83

Open
FlorianLudwig opened this issue Feb 5, 2017 · 2 comments
Open

Merge pixi-layout and pixi-shapes back into GOWN.js #83

FlorianLudwig opened this issue Feb 5, 2017 · 2 comments
Assignees

Comments

@FlorianLudwig
Copy link
Member

I am thinking about merging the three projects back together into one.

Reasoning:

  1. less to maintain (one bug tracker instead of three)
  2. make it simpler for newcomers to find there way around and actually built gown successfully
  3. claim: they are not in use separately from gown anyway
@brean
Copy link
Collaborator

brean commented Feb 5, 2017

I don't know of anybody who uses them separately, including myself ;-) . It looked as a good idea to have this basic functionalty as own projects.

I can think of 3 reasons why you might consider keeping them appart:

  1. A project where you only want layouting or the shapes without the whole gown and want to save a few bytes bandwith and.
  2. Lets say another developer only want to draw some basic shapes (stars, arrows, ...) for his project. He searches for pixi shapes and might not find gown so he uses some other lib or implements it himself. Later he wants to also include some more complex ui, so he adds gown, and now he has different libs in there that provide the same functionality.
  3. it should make it easier for other developers who are only interested in shapes or layouts. They only need to understand and extend one of the smaller libs and don't need the whole.

But because both projects are so small the saved bandwith is not measurable and a few lines of duplicated functionality is not so bad (in my 2. example the developer did bad planning from the start, anyway). And until now noone seemed very interested in just pixi-shapes or pixi-layout so the possibility for any of these projects to grow on their own are quite low.

I think maintability is the most important thing here. So if you think that this will make things easier for us go ahead and merge them back.

@brean brean self-assigned this Feb 19, 2017
@DennisSmolek
Copy link

You could always leave them as separate modules that don't HAVE to be imported.. So a core, gown, shapes, layout..

Angular did this with Angular2. Animations, Routing, etc. is individual modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants