Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customComponent of type object supplied to ColumnDefinition, expected function. in ColumnDefinition in new griddle-react #864

Open
mkotar opened this issue May 28, 2020 · 1 comment

Comments

@mkotar
Copy link

mkotar commented May 28, 2020

Griddle version

"griddle-react": "1.13.1", but tested also on "1.13.0"
"react-redux": "^7.2.0",

Actual Behavior

Failed prop type: Invalid prop customComponent of type object supplied to ColumnDefinition, expected function.
in ColumnDefinition

Any idea how to fix it ? Code is basically copied from documentation and still getting this error

Steps to reproduce

<ColumnDefinition id="serialNumber"
                                                         title={translate('recorders.serialNumber')}
                                                          customComponent={enhancedWithRowData(this.getRecorderSerialNumber)}
                                                          width={50}/>

and

private getRecorderSerialNumber = ({rowData}) => {
        return (
            <div className={style.link}>
                <Link to={`/recorders/${rowData.id}/view`}>{rowData.serialNumber}</Link>
            </div>
        );
    };
        enhancedWithRowData: connect((internalState: any, props: any) => {
            return {
                rowData: rowDataSelector(internalState, props)
            };
        }),
export const rowDataSelector = (state: any, params: any) => {
    return state
        .get('data')
        .find(rowMap => rowMap.get('griddleKey') === params.griddleKey)
        .toJSON();
}
@aaronsmulktis
Copy link

👆 Same versions for me, same issue for me.

This is a great package btw, been using it for years, so thank you. Guess this is just the first time I'm diving deep enough to want custom rowData.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants