Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Process, Network, and Memory modules into different feature #965

Open
mokeyish opened this issue Apr 1, 2023 · 9 comments
Open

Comments

@mokeyish
Copy link

mokeyish commented Apr 1, 2023

Could you separate Process, Network, and Memory into different feature that I can enable feature flag on demand?

@GuillaumeGomez
Copy link
Owner

What advantage do you expect from this?

@mokeyish
Copy link
Author

mokeyish commented Apr 1, 2023

Thanks, I want to use Process only.

@GuillaumeGomez
Copy link
Owner

You can already if you only refresh processes. Hence my question.

@zeenix
Copy link
Contributor

zeenix commented May 4, 2023

You can already if you only refresh processes. Hence my question.

What @mokeyish means is to allow disabling build of all the parts that are not needed by the application/library using sysinfo. Cargo.toml snippet:

sysinfo = { version = "...", default-features = false, features = ["prcoess"] }

@GuillaumeGomez
Copy link
Owner

No I understood, but my question is really about what advantages they expect from having cfged parts of the API: I expect a small improvement in compilation time but apart from that I don't really see any big advantage.

@zeenix
Copy link
Contributor

zeenix commented May 4, 2023

No I understood, but my question is really about what advantages they expect from having cfged parts of the API: I expect a small improvement in compilation time but apart from that I don't really see any big advantage.

True but you know when you have lots of deps, small improvement from buildtime of each dep adds up fast.

@GuillaumeGomez
Copy link
Owner

True. It's something I'm interested into in the long run, but the code needs to be cleaned up a lot more before going into this, otherwise it'll be unmaintainable.

@mokeyish
Copy link
Author

mokeyish commented May 6, 2023

What @mokeyish means is to allow disabling build of all the parts that are not needed by the application/library using sysinfo. Cargo.toml snippet:

sysinfo = { version = "...", default-features = false, features = ["prcoess"] }

Yes, this is exactly what I mean.

@GuillaumeGomez
Copy link
Owner

Just for information, I'm currently working on separating components (#1063). After it's done, it'll be possible to think about this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants