Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill Proxy in tests to throw errors for undefined chai property assertions #7895

Closed
crookedneighbor opened this issue Aug 12, 2016 · 6 comments

Comments

@crookedneighbor
Copy link
Contributor

Cha now supports throwing errors on undefined properties chaijs/chai#721

IE writing

expect(foo).to.exists;

Will fail because the property should be exist

However, it requires Proxies (available in Node 6). Until we can upgrade to Node 6, we should see if we can polyfill Proxy in tests to get this behavior.

@paglias
Copy link
Contributor

paglias commented Aug 13, 2016

@crookedneighbor
Copy link
Contributor Author

Looks like the PR I mentioned has been merged in, but is slated for the 4.0.0 release.

@paglias
Copy link
Contributor

paglias commented Aug 21, 2016

Waiting for 4.0 release

@lemoness
Copy link
Contributor

Is this still something that needs to be done?

@paglias
Copy link
Contributor

paglias commented Oct 19, 2017

Yes, it's something that would be nice to have and it's not on hold anymore but very low priority

@lemoness
Copy link
Contributor

I've updated the labels on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants