New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version does not open popup inside table #937
Comments
I'd love to get this fixed. It shouldn't be a complex bug. But for personal reasons I'm going to be away from PC for some time. If someone could come up with a PR it would be awesome. |
I am also having issue as a result of switching from |
To clarify for future reference, the version under discussion is 0.49 and this change:
Workaround: Revert back to 0.48 for the mean time. |
@evolve2k I cannot because it fails in Jest test with: Invariant Violation: getNodeFromInstance: Invalid argument. |
the table bug should be fairly easy to fix if anyone wants to give it a shot in the Popper.js repo |
This project is using "react-popper", not "popper.js" by FezVrasta (which should have solved this problem since 1.11.0). |
react-popper depends on popper.js@1.x so you are able to update the popper.js version independently |
Does anyone have a concrete solution ? |
@pierre-H did you try bumping popper.js to 1.11.0? |
Perhaps #1001 might help? |
@martijnrusschen, with the caret dependencies, it can be bumped independently -- it only locks in the first non-zero number, and from what I can tell the recent react-popper dependencies on popper.js are also carets. Regardless, we should make that change =) |
Ah yes, just upgrading it for my own sanity to get it removed from the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It seems like migration to popper.js broke popup position.
I think it has something related to floating-ui/floating-ui#276
The text was updated successfully, but these errors were encountered: