Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version does not open popup inside table #937

Closed
vitalii-komenda opened this issue Jul 10, 2017 · 13 comments
Closed

Latest version does not open popup inside table #937

vitalii-komenda opened this issue Jul 10, 2017 · 13 comments
Labels

Comments

@vitalii-komenda
Copy link

It seems like migration to popper.js broke popup position.
I think it has something related to floating-ui/floating-ui#276

@FezVrasta
Copy link

I'd love to get this fixed. It shouldn't be a complex bug. But for personal reasons I'm going to be away from PC for some time. If someone could come up with a PR it would be awesome.

@bradbirnbaum
Copy link

I am also having issue as a result of switching from tether to popper

@evolve2k
Copy link

To clarify for future reference, the version under discussion is 0.49 and this change:

  • Migrate from tether.io to popper.js for handling calendar popups

Workaround: Revert back to 0.48 for the mean time.

@vitalii-komenda
Copy link
Author

@evolve2k I cannot because it fails in Jest test with: Invariant Violation: getNodeFromInstance: Invalid argument.

@FezVrasta
Copy link

the table bug should be fairly easy to fix if anyone wants to give it a shot in the Popper.js repo

@f2net
Copy link

f2net commented Aug 9, 2017

This project is using "react-popper", not "popper.js" by FezVrasta (which should have solved this problem since 1.11.0).

@FezVrasta
Copy link

react-popper depends on popper.js@1.x so you are able to update the popper.js version independently

@pierre-H
Copy link

Does anyone have a concrete solution ?
I have the bug inside a table...

@rafeememon
Copy link
Contributor

@pierre-H did you try bumping popper.js to 1.11.0?

@martijnrusschen
Copy link
Member

Perhaps #1001 might help?

@rafeememon
Copy link
Contributor

rafeememon commented Aug 24, 2017

@martijnrusschen, with the caret dependencies, it can be bumped independently -- it only locks in the first non-zero number, and from what I can tell the recent react-popper dependencies on popper.js are also carets. Regardless, we should make that change =)

@martijnrusschen
Copy link
Member

Ah yes, just upgrading it for my own sanity to get it removed from the yarn outdated list in that case :)

@stale
Copy link

stale bot commented Aug 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 30, 2019
@stale stale bot closed this as completed Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants