-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle file extensions case sensitive #3542
Conversation
Thanks! Could you add a test as well? |
All tests passed locally |
…, check that there is no error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I just made a change to make the tests less confusing.
Ready to go if you are |
Forgot to mention, #3549 is not fixed here. Do you want to do that here? I was thinking it would need more discussion and refactoring and could be its own PR. |
Yeah lets tackle the other issue too |
Yes that can be a separate PR, whatever you want |
Im stuck on the test where adding an extension with different casing is supposed to ignore the casing if the letters are the same. Makes no sense to me. |
I'm not sure what you mean, but if you create a PR with a test that is not working properly I might be able to help |
theres your failing tests |
Now I understand your comment, if you were wondering why extensions were case insensitive: the code was probably written (six years ago) with only Windows in mind. However, even though some things might technically work on Windows I think we should encourage LaTeX that also works on Linux, so that failing test is not something we want to support anymore. I have one failing test locally because it finds myOtherPicture.png but that file doesn't exist anymore, strange. |
# Conflicts: # src/nl/hannahsten/texifyidea/completion/pathcompletion/LatexPathProviderBase.kt
I saw that too. Just occurred to me that I should maybe delete the build dir |
Fix #3537 on how to test.
What was happening was twofold: the casing on extensions was being thrown out at command definition, and when testing different exts, it would also discard the requested casing. This doesnt matter on 🪟, because checking for little
jpg
or bigJPG
would give the same result from the fs.