Refactoring Image Name can delete extension

[jojo2357]

\includegraphics{ima<caret>ge}

whilst you have a good reference to image.png, refactor it (ctrl + f6).

The whole name will be higlighted, including the .png part. Doing the refactor from the files view has the expected behavior of omitting the extension in the refactor dialog.

[jojo2357]

Found the reason.

In com.intellij.refactoring.rename.RenameDialog#createNewNameComponent(), lines 157-159 (below for clarity), is where we go wrong. When refactoring from the files view, myEditor is null, and from the latex file, it is nonnull.

if (myPsiElement instanceof PsiFile && myEditor == null) {
  myNameSuggestionsField.selectNameWithoutExtension();
}

I might be lost, or I might figure it out, who knows? A full stack trace (sans the mentioned code above) is provided.

<init>:81, RenameDialog (com.intellij.refactoring.rename)
<init>:23, RenameWithOptionalReferencesDialog (com.intellij.refactoring.rename)
<init>:49, RenamePsiFileProcessor$PsiFileRenameDialog (com.intellij.refactoring.rename)
createRenameDialog:27, RenamePsiFileProcessor (com.intellij.refactoring.rename)
createDialog:27, RenamePsiElementProcessor (com.intellij.refactoring.rename)
rename:204, PsiElementRenameHandler (com.intellij.refactoring.rename)
invoke:129, PsiElementRenameHandler (com.intellij.refactoring.rename)
invoke:102, PsiElementRenameHandler (com.intellij.refactoring.rename)
invoke:85, PsiElementRenameHandler (com.intellij.refactoring.rename)
performRefactoringAction:164, BaseRefactoringAction (com.intellij.refactoring.actions)
performRename:38, RenameHandler2Renamer (com.intellij.refactoring.rename)
+ actionPerformed:88, RenameElementAction (com.intellij.refactoring.actions)
doPerformActionOrShowPopup:305, ActionUtil (com.intellij.openapi.actionSystem.ex)
performAction:32, ActionProcessor (com.intellij.openapi.keymap.impl)
performAction:495, IdeKeyEventDispatcher$actionProcessor$1 (com.intellij.openapi.keymap.impl)
doPerformActionInner$lambda$4$lambda$3:844, IdeKeyEventDispatcherKt (com.intellij.openapi.keymap.impl)
run:-1, IdeKeyEventDispatcherKt$$Lambda$3576/0x0000000101a8f7a0 (com.intellij.openapi.keymap.impl)
performActivity:106, TransactionGuardImpl (com.intellij.openapi.application)
performUserActivity:95, TransactionGuardImpl (com.intellij.openapi.application)
doPerformActionInner$lambda$4:844, IdeKeyEventDispatcherKt (com.intellij.openapi.keymap.impl)
run:-1, IdeKeyEventDispatcherKt$$Lambda$3570/0x0000000101a7e098 (com.intellij.openapi.keymap.impl)
lambda 'use' in 'performWithActionCallbacks':1161, ActionManagerImpl (com.intellij.openapi.actionSystem.impl)
lambda 'use' in 'performWithActionCallbacks':1160, ActionManagerImpl (com.intellij.openapi.actionSystem.impl)
performWithActionCallbacks:1159, ActionManagerImpl (com.intellij.openapi.actionSystem.impl)
performDumbAwareWithCallbacks:322, ActionUtil (com.intellij.openapi.actionSystem.ex)
doPerformActionInner:842, IdeKeyEventDispatcherKt (com.intellij.openapi.keymap.impl)
access$doPerformActionInner:1, IdeKeyEventDispatcherKt (com.intellij.openapi.keymap.impl)
processAction$intellij_platform_ide_impl:571, IdeKeyEventDispatcher (com.intellij.openapi.keymap.impl)
processAction:508, IdeKeyEventDispatcher (com.intellij.openapi.keymap.impl)
processActionOrWaitSecondStroke:447, IdeKeyEventDispatcher (com.intellij.openapi.keymap.impl)
inInitState:440, IdeKeyEventDispatcher (com.intellij.openapi.keymap.impl)
dispatchKeyEvent:302, IdeKeyEventDispatcher (com.intellij.openapi.keymap.impl)
dispatchKeyEvent:622, IdeEventQueue (com.intellij.ide)
_dispatchEvent$lambda$11:585, IdeEventQueue (com.intellij.ide)
run:-1, IdeEventQueue$$Lambda$3551/0x0000000101a58688 (com.intellij.ide)
runWithEnabledImplicitRead:138, RwLockHolder (com.intellij.openapi.application.impl)
runWithImplicitRead:129, RwLockHolder (com.intellij.openapi.application.impl)
_dispatchEvent:585, IdeEventQueue (com.intellij.ide)
access$_dispatchEvent:77, IdeEventQueue (com.intellij.ide)
compute:362, IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1 (com.intellij.ide)
compute:361, IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1 (com.intellij.ide)
computePrioritized:843, CoreProgressManager (com.intellij.openapi.progress.impl)
invoke:361, IdeEventQueue$dispatchEvent$processEventRunnable$1$1 (com.intellij.ide)
invoke:356, IdeEventQueue$dispatchEvent$processEventRunnable$1$1 (com.intellij.ide)
performActivity$lambda$1:1021, IdeEventQueueKt (com.intellij.ide)
run:-1, IdeEventQueueKt$$Lambda$1251/0x0000000100b7e288 (com.intellij.ide)
performActivity:114, TransactionGuardImpl (com.intellij.openapi.application)
performActivity:1021, IdeEventQueueKt (com.intellij.ide)
dispatchEvent$lambda$7:356, IdeEventQueue (com.intellij.ide)
run:-1, IdeEventQueue$$Lambda$1250/0x0000000100b79ee8 (com.intellij.ide)
runIntendedWriteActionOnCurrentThread:209, RwLockHolder (com.intellij.openapi.application.impl)
runIntendedWriteActionOnCurrentThread:830, ApplicationImpl (com.intellij.openapi.application.impl)
dispatchEvent:398, IdeEventQueue (com.intellij.ide)
pumpOneEventForFilters:207, EventDispatchThread (java.awt)
pumpEventsForFilter:128, EventDispatchThread (java.awt)
pumpEventsForHierarchy:117, EventDispatchThread (java.awt)
pumpEvents:113, EventDispatchThread (java.awt)
pumpEvents:105, EventDispatchThread (java.awt)
run:92, EventDispatchThread (java.awt)