Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy url of post or comment to clipboard directly not via Android share #3026

Open
mcarans opened this issue Jun 11, 2019 · 4 comments · May be fixed by #3162
Open

Add copy url of post or comment to clipboard directly not via Android share #3026

mcarans opened this issue Jun 11, 2019 · 4 comments · May be fixed by #3162
Labels
Enhancement This issue is requesting/proposing a change that will better a feature or aspect of Slide. Feedback This issue is giving feedback on Slide. Has Solution There is a solution to this issue posted in the comment. High Priority This issue is high on our todo list. It needs to be fixed as soon as possible.

Comments

@mcarans
Copy link

mcarans commented Jun 11, 2019 •
edited

Non stock ROMs like LineageOS do not have the copy to clipboard function in the share menu. For non stock ROMs and for the convenience in stock ROMs (less clicks) , there should be an option to copy the url of a post or comment to clipboard directly in Slide.
@mcarans mcarans changed the title Add option to copy url of post or comment to clipboard Add copy url of post or comment to clipboard directly not via Android share Jun 12, 2019
@timawesomeness
Copy link
Contributor

timawesomeness commented Jun 29, 2019 •
edited

I've been trying to come up with somewhere to put it, the overflow bottom sheet is already way too long so I can't just add it as another option there. I also can't really put it anywhere special in the bottom sheet either, the bottom sheet library we're using doesn't support much customization.

If I find a good place to put it, I'll implement it immediately. I hate copying to clipboard from the share menu.

@mcarans
Copy link
Author

mcarans commented Jun 29, 2019

Thanks for looking at it. I notice that there is already a Save icon next to edit so that option could be removed from the menu (as no need to have it in two places) and the new copy url to clipboard option added.

Alternatively, maybe the bottom 4 options could be under a separate share icon next to the Edit and Save icons along with the new copy url to clipboard option.

@Tensounder54 Tensounder54 added Enhancement This issue is requesting/proposing a change that will better a feature or aspect of Slide. Feedback This issue is giving feedback on Slide. Has Solution There is a solution to this issue posted in the comment. High Priority This issue is high on our todo list. It needs to be fixed as soon as possible. labels Jul 2, 2019
@goforbg
Copy link

goforbg commented May 3, 2020

I've been thinking of a solution where we can just copy the URL to clipboard on clicking the "share link button" and show a toast before inflating the bottom sheet?

@mcarans
Copy link
Author

mcarans commented May 4, 2020

Sounds great to me!

@goforbg goforbg linked a pull request May 4, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement This issue is requesting/proposing a change that will better a feature or aspect of Slide. Feedback This issue is giving feedback on Slide. Has Solution There is a solution to this issue posted in the comment. High Priority This issue is high on our todo list. It needs to be fixed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes 3026: auto-copy URL for old devices goforbg/Slide
4 participants
@timawesomeness @goforbg @mcarans @Tensounder54