Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] some issues with sideloads #3767

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[FIX] some issues with sideloads #3767

wants to merge 7 commits into from

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented May 18, 2024 •
edited

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@a931vwewi a931vwewi mentioned this pull request May 19, 2024
Open
@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 28, 2024
@arielj
Copy link
Collaborator

arielj commented Jun 1, 2024

I'm trying to reproduce what you mention of the End of log printed early but I can't reproduce that, I tried 3 sideloaded games and that always happens at the end

arielj
arielj reviewed Jun 1, 2024
View reviewed changes
src/backend/launcher.ts
@@ -1019,6 +1020,13 @@ async function callRunner(
// requires a "./"
if (!isWindows) bin = './' + bin

// this must be a native sideload
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this comment mean? that at this point we are sure this is a native sideloaded game? I don't understand it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that at this point we are sure this is a native sideloaded game yes that's what it means :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielj arielj Awaiting requested review from arielj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mangohud no longer appears
2 participants
@Etaash-mathamsetty @arielj