env_config: add HOMEBREW_BUNDLE_USER_CACHE.
#17327
Conversation
Won't be needed for users who set |
Used to configure `BUNDLE_USER_CACHE`.
MikeMcQuaid
force-pushed
the
bundle_user_cache_again
branch
from
d769939
to
0c17665
Compare
| @@ -91,6 +91,9 @@ module EnvConfig | |||
| description: "Use this as the browser when opening project homepages.", | |||
| default_text: "`$BROWSER` or the OS's default browser.", | |||
| }, | |||
| HOMEBREW_BUNDLE_USER_CACHE: { | |||
| description: "If set, use this directory as the `bundle`(1) user cache.", | |||
There was a problem hiding this comment.
Should we default to a location inside HOMEBREW_CACHE? Otherwise we would write to HOME, which is weird.
There was a problem hiding this comment.
I don't understand the request, asking for a HOMEBREW_CACHE default is just asking for this PR to be closed and keep #17324 functionality?
I don't think we should have or need a default at all. The existing logic was fine for everyone except dkav.
Alternatively: we rip out all this logic and make #17276 a WONTFIX. Really not convinced this is worth the amount of effort that's gone into it and definitely not worth any more.
There was a problem hiding this comment.
I don't understand the request, asking for a
HOMEBREW_CACHEdefault is just asking for this PR to be closed and keep #17324 functionality?
Not necessarily; we can simply add a default: key here. Will make an in-line suggestion below.
I don't think we should have or need a default at all. The existing logic was fine for everyone except dkav.
Ok, that's fine! I just agreed with you when you said not writing to HOME would be ideal. But I'm not hugely bothered by it, so we can leave this as it is.
There was a problem hiding this comment.
| description: "If set, use this directory as the `bundle`(1) user cache.", | |
| description: "If set, use this directory as the `bundle`(1) user cache.", | |
| default: "#{HOMEBREW_DEFAULT_CACHE}/bundler_cache", |
There was a problem hiding this comment.
I just agreed with you when you said not writing to
HOMEwould be ideal. But I'm not hugely bothered by it, so we can leave this as it is.
Sorry, yeh, provided insufficient context here: there's additional complexity from not writing to HOME e.g. permissions, directory not existing, etc. that means that I think it's not worthwhile given the level of demand we've seen (one person 😅)
| @@ -91,6 +91,9 @@ module EnvConfig | |||
| description: "Use this as the browser when opening project homepages.", | |||
| default_text: "`$BROWSER` or the OS's default browser.", | |||
| }, | |||
| HOMEBREW_BUNDLE_USER_CACHE: { | |||
| description: "If set, use this directory as the `bundle`(1) user cache.", | |||
There was a problem hiding this comment.
I don't understand the request, asking for a
HOMEBREW_CACHEdefault is just asking for this PR to be closed and keep #17324 functionality?
Not necessarily; we can simply add a default: key here. Will make an in-line suggestion below.
I don't think we should have or need a default at all. The existing logic was fine for everyone except dkav.
Ok, that's fine! I just agreed with you when you said not writing to HOME would be ideal. But I'm not hugely bothered by it, so we can leave this as it is.
| @@ -91,6 +91,9 @@ module EnvConfig | |||
| description: "Use this as the browser when opening project homepages.", | |||
| default_text: "`$BROWSER` or the OS's default browser.", | |||
| }, | |||
| HOMEBREW_BUNDLE_USER_CACHE: { | |||
| description: "If set, use this directory as the `bundle`(1) user cache.", | |||
There was a problem hiding this comment.
| description: "If set, use this directory as the `bundle`(1) user cache.", | |
| description: "If set, use this directory as the `bundle`(1) user cache.", | |
| default: "#{HOMEBREW_DEFAULT_CACHE}/bundler_cache", |
|
Thanks @carlocab! |
Used to configure
BUNDLE_USER_CACHE.Changes approach in #17324 where I saw some local issues if e.g. the directory wasn't created or had weird permissions.
CC @dkav that you'll need to set this variable now.