Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Storybook: Outdated addon-info leading to wrong code styling #238

Open
ocBruno opened this issue Jan 24, 2020 · 3 comments
Open

Storybook: Outdated addon-info leading to wrong code styling #238

ocBruno opened this issue Jan 24, 2020 · 3 comments
Assignees
@RobertoMSousa
Labels
bug Something isn't working good first issue Good for newcomers in progress
Projects
Version 2.0
Milestone
v1.0.0

Comments

@ocBruno
Copy link
Contributor

ocBruno commented Jan 24, 2020 •
edited

馃悰 Bug Report

Complete bug report and reproduction steps in detail in following issue >
https://github.com/storybookjs/storybook/issues/9618

According to one of the contributors of storybook, addon-info is being superceded by addon-docs which resolves various bugs and is easier to maintain. I suggest we follow the suggestion and change the config to resolve this styling problem and reap of the other benefits.

I'm giving this a shot atm but if anyone with more experience with storybook and/or the project config wants to take over or shine some light on the subject feel free!

Reference links:
-https://www.npmjs.com/package/@storybook/addon-docs#typescript-configuration
@ocBruno ocBruno changed the title outdated addon-info leading to code styling bug Bug(Storybook): Outdated addon-info leading to wrong code styling Jan 24, 2020
@ocBruno ocBruno changed the title Bug(Storybook): Outdated addon-info leading to wrong code styling Bug(storybook): Outdated addon-info leading to wrong code styling Jan 24, 2020
@matteovivona matteovivona added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jan 25, 2020
@matteovivona matteovivona added this to the v1.0.0 milestone Jan 25, 2020
@matteovivona matteovivona added this to To do in Version 2.0 via automation Jan 25, 2020
@ocBruno ocBruno mentioned this issue Jan 26, 2020
Closed
@matteovivona matteovivona changed the title Bug(storybook): Outdated addon-info leading to wrong code styling Storybook: Outdated addon-info leading to wrong code styling Feb 20, 2020
@RobertoMSousa
Copy link
Contributor

馃憢 , I can take care of this. I can give a look on the addons we have and can get updated and install some new ones.
Especially the accessibility one because on a health-related website the accessibility should be a must.

@matteovivona matteovivona added in progress and removed help wanted Extra attention is needed labels Oct 18, 2020
@matteovivona
Copy link
Contributor

@RobertoMSousa good work and thanks!

@RobertoMSousa RobertoMSousa mentioned this issue Oct 20, 2020
Merged
@RobertoMSousa
Copy link
Contributor

RobertoMSousa commented Oct 24, 2020 •
edited

List of components that need to be updated

  • Alert
  • Badge
  • Breadcrumb
  • Button
  • Calendar
  • Callout
  • Checkbox
  • DateTimePicker
  • DropDown
  • Graph
  • Icon
  • Image
  • Label
  • Layout
  • List
  • Modal
  • NavBar
  • Panel
  • Pill
  • Radio
  • RichText
  • Select
  • Spinner
  • Switch
  • Tab
  • Table
  • TextField
  • TextInput
  • Toaster
  • Typeahead
  • Typography
  • VideoPlayer

@RobertoMSousa RobertoMSousa mentioned this issue Oct 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RobertoMSousa RobertoMSousa

Labels
bug Something isn't working good first issue Good for newcomers in progress
Projects
Version 2.0
  
To do
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

WIP: feat(storybook): add addon-docs
3 participants
@matteovivona @RobertoMSousa @ocBruno