Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnerabilities with ESLint dependencies minimist and acorn #133

Closed
miketalley opened this issue Mar 16, 2020 · 2 comments
Closed

Fix vulnerabilities with ESLint dependencies minimist and acorn #133

miketalley opened this issue Mar 16, 2020 · 2 comments
Assignees
@miketalley

Comments

@miketalley
Copy link
Contributor

We have a couple vulnerabilities that started showing in Github. It looks like they are related to ESLint dependencies.

Once ESLint updates their dependencies, we should be able to upgrade the version that we are using to fix the issue.

See eslint/eslint#13050
@miketalley miketalley self-assigned this Mar 16, 2020
@miketalley
Copy link
Contributor Author

Looks like ESLint is not going to update their deps because there is a workaround for this here.

I'm going to recreate yarn.lock and see if that solves this.

@gcorne
Copy link
Contributor

gcorne commented Apr 3, 2020

After updating lerna and its deps in #158, this is fixed.

@gcorne gcorne closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketalley miketalley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcorne @miketalley