Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme preview link can be inaccurate #600

Open
anthmatic opened this issue Nov 15, 2021 · 0 comments
Open

Theme preview link can be inaccurate #600

anthmatic opened this issue Nov 15, 2021 · 0 comments

Comments

@anthmatic
Copy link
Contributor

Description and Context

While looking into #596 I did found a flaw in the way this link is generated. If the theme is uploaded to a different folder, the preview link will not be accurate

Steps to reproduce

hs upload "cool theme" theme2000 would yield a link to /theme-previewer/1234567/edit/cool%20theme when it should point to /theme-previewer/1234567/edit/theme2000

Expected behavior

Theme preview link should be based on the destination path in the developer filesystem

Screenshots

Who to Notify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant