Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let "hs watch" only upload changed files #613

Open
arinker opened this issue Dec 1, 2021 · 4 comments
Open

Let "hs watch" only upload changed files #613

arinker opened this issue Dec 1, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@arinker
Copy link

arinker commented Dec 1, 2021

Description and Context

The hs watch command uploads each file as soon as the file is saved without checking if the file has changed.
This significantly slows down the development process with any build tool (Webpack, Vitejs, ...).

Steps to reproduce

Just open a file in a folder watched by hs watch and save it without any changes while hs watch is running.

Expected behavior

hs watch should only upload files with a new checksum.

Who to Notify

@arinker

@anthmatic anthmatic added the enhancement New feature or request label Dec 9, 2021
@anthmatic
Copy link
Contributor

@arinker I'm not sure if this is something we'd consider in the near term, however I've marked it as an enhancement for now.

Have you seen https://www.npmjs.com/package/@hubspot/webpack-cms-plugins? It is webpack specific but might be useful in your workflow.

@igor-duspara
Copy link

Is there some new information about this feature? It would really improve our Development Workflow.

@jsines jsines self-assigned this Jul 11, 2023
@jsines
Copy link
Contributor

jsines commented Jul 11, 2023

Dug into this a bit today, the library we use for watching files (chokidar) emits the change event even if there are no changes to the saved file and has no option to ignore. I've filed an issue to fix this: paulmillr/chokidar#1283

I could work around it in the mean time, either by converting to a means file watching that doesn't have this problem or implementing the feature myself, but it may take a little longer than expected.

@AndoniH11
Copy link

Hey @jsines ! Glad to hear that this feature is something you are working on.

Do you have any estimations about when could this feature new be launched?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants