Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with 'model scope' and 'morphology' field relation #270

Open
appukuttan-shailesh opened this issue Jun 29, 2020 · 0 comments

Comments

@appukuttan-shailesh
Copy link
Collaborator

appukuttan-shailesh commented Jun 29, 2020

Model has a field named 'model_scope'
Model instance has a field named 'morphology'

Only models with model_scope = "single cell" or "network*" should be allowed to specify 'morphology' field.

Potential problem:
If a user makes a model with, say, model scope = "single cell", and adds a couple of model instances with the morphologies specified. Now if later they edit the model to change model scope to something else (e.g. subcellular).... then what do we do with the existing instances with morphology field.

@apdavison's comment:
It’s not a simple problem. The underlying KG representation is different for the two cases (MEModel vs generic ModelInstance). Probably the simplest way to avoid problems is to disallow changing model scope from “single cell” to anything else.

(Since the scenario may never arise, we could address this later).

Update:
I imagine this to be a more generic problem (not just restricted to 'morphology' field usage), in that model_scope cannot be easily "edited" from any option to another. I think there is a need for more work on this..... disable editing of 'model_scope' completely or something that handles all combos of changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant