Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Punctuation Breaking Link Detection #408

Open
rudolphventer opened this issue Nov 2, 2022 · 3 comments
Open

Japanese Punctuation Breaking Link Detection #408

rudolphventer opened this issue Nov 2, 2022 · 3 comments
Assignees
Milestone

Comments

@rudolphventer
Copy link

Hi, in Japanese it is common to quote links in brackets like so 続行する前に、このリンク「https://testdomain.com」を参照してください。

This causes an issue with Linkify where the rest of the paragraph after the link is also linkified as the char does not have any whitespace after it as the character itself seems to contain a space.

This usage is equivalent to the use of round brackets which Linkify does account for, i.e there will always be an opening and closing bracket. Would it be possible to add these brackets to the existing bracket logic?

There are three types of brackets used this way 「 」,『』and【】

@nfrasser
Copy link
Collaborator

Hi @rudolphventer, thanks for reporting, will consider this for a future release.

@Sapphire2k
Copy link

What's more,(https://testdomain.com)test param or a paragraph also will be linkified, can we add some exclude characters to ignore ?

@GuiLeme
Copy link

GuiLeme commented Jul 19, 2023

Hey guys, I mentioned this issue in one of our PRs, because it seems that this happens also with letters that come before the https protocol mark such as examplehttps://, this becames clearer when dealing with japanese sentences as showed in our issue bigbluebutton/bigbluebutton#18313.

Considering that, we had a quick fix, but we would like to know if you guys are planning on dealing with the scenario I brought, or just punctuations before the link.

Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants