Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Change the Kind cluster ingress configuration #130

Open
2 tasks done
roytman opened this issue May 15, 2024 · 3 comments
Open
2 tasks done

[Feature] Change the Kind cluster ingress configuration #130

roytman opened this issue May 15, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@roytman
Copy link
Member

roytman commented May 15, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Other

Feature

The current ingress configuration is that MinIO takes the default root URL path. Kfp requests should start from kfp/. The finishing slash is important; without it, Nginx forwards user requests to MinIO, which leads to user confusion.
From a user perspective, the KFP entry point is not just important, it's the main entry point. This emphasis guides users and enhances the overall usage of the system.

Note: the nginx has the Ray API Server ingress as well.
Note: the changes requires updates in teh installation scripts and in the documentation.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@roytman roytman added the enhancement New feature or request label May 15, 2024
@blublinsky
Copy link
Collaborator

The current ingress configuration is that MinIO takes the default root URL path. That is the only option to make mc work correctly. Changing Minio URL path to anything else is going to break mc usage, see https://min.io/docs/minio/linux/reference/minio-mc/mc-alias.html

@blublinsky
Copy link
Collaborator

@roytman I think it what it is for now

@roytman
Copy link
Member Author

roytman commented May 17, 2024

we can run 2 separate ingress controllers: one for KFP as a main user entry point and another one for testing/debugging with MinIO and Ray
it will prevent user confusions

D-Sai-Venkatesh pushed a commit to D-Sai-Venkatesh/data-prep-kit that referenced this issue May 21, 2024
roytman added a commit that referenced this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants