Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document if changed files got excluded from build scope #491

Closed
dennis-behm opened this issue Mar 20, 2024 · 1 comment · Fixed by #492
Closed

Document if changed files got excluded from build scope #491

dennis-behm opened this issue Mar 20, 2024 · 1 comment · Fixed by #492

Comments

@dennis-behm
Copy link
Member

The computation of changed files validates identified changes against the excludeFileList to exclude files from the build.

In verbose mode, the excluded changes should be documented as being excluded from the build list. Add the necessary else fork as well. See:

if (props.verbose) println "*** Changed files for directory $dir $msg:"
changed.each { file ->
(file, mode) = fixGitDiffPath(file, dir, true, null)
if ( file != null ) {
if ( !buildUtils.matches(file, excludeMatchers)) {
changedFiles << file
if (!calculateConcurrentChanges) githashBuildableFilesMap.addFilePattern(abbrevCurrent, file)
if (props.verbose) println "**** $file"
}
//retrieving changed build properties
if (props.impactBuildOnBuildPropertyChanges && props.impactBuildOnBuildPropertyChanges.toBoolean() && file.endsWith(".properties")){
if (props.verbose) println "**** $file"
String gitDir = new File(buildUtils.getAbsolutePath(file)).getParent()
String pFile = new File(buildUtils.getAbsolutePath(file)).getName()
changedBuildProperties.addAll(gitUtils.getChangedProperties(gitDir, baseline, current, pFile))
}
}
}
if (props.verbose) println "*** Deleted files for directory $dir $msg:"
deleted.each { file ->
if ( !buildUtils.matches(file, excludeMatchers)) {
(file, mode) = fixGitDiffPath(file, dir, false, mode)
deletedFiles << file
if (props.verbose) println "**** $file"
}
}
if (props.verbose) println "*** Renamed files for directory $dir $msg:"
renamed.each { file ->
if ( !buildUtils.matches(file, excludeMatchers)) {
(file, mode) = fixGitDiffPath(file, dir, false, mode)
renamedFiles << file
if (props.verbose) println "**** $file"
}
}

@dennis-behm
Copy link
Member Author

Delivered via zAppBuild 3.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant