fix(errors): restore matching against all original errors #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed an error origination point that needed to be converted to the new format. Also, this is maybe overly cautious but I added back in the original error instances as native caused by errors for all instances. Before, I intentionally left alone places that held an error origination from `fmt.Errorf()` because I don't know that users can really match against those, but I figured we might as well be as compatibility-friendly as we can be, since it doesn't cost us anything. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
commented
Mar 21, 2024
| @@ -143,7 +143,8 @@ func (requestBuilder *RequestBuilder) ConstructHTTPURL(serviceURL string, pathSe | |||
| // The resulting request URL: "https://myservice.cloud.ibm.com/resource/res-123-456-789-abc/type/type-1" | |||
| func (requestBuilder *RequestBuilder) ResolveRequestURL(serviceURL string, path string, pathParams map[string]string) (*RequestBuilder, error) { | |||
| if serviceURL == "" { | |||
| return requestBuilder, fmt.Errorf(ERRORMSG_SERVICE_URL_MISSING) | |||
| err := fmt.Errorf(ERRORMSG_SERVICE_URL_MISSING) | |||
| return requestBuilder, SDKErrorf(err, "", "service-url-missing", getComponentInfo()) | |||
There was a problem hiding this comment.
This was the real issue that needed to be fixed
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 21, 2024
## [5.16.3](v5.16.2...v5.16.3) (2024-03-21) ### Bug Fixes * **errors:** restore matching against all original errors ([#213](#213)) ([005fdb8](005fdb8))
|
🎉 This PR is included in version 5.16.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed an error origination point that needed to be converted to the new format. Also, this is maybe overly cautious but I added back in the original error instances as native caused by errors for all instances. Before, I intentionally left alone places that held an error origination from
fmt.Errorf()because I don't know that users can really match against those, but I figured we might as well be as compatibility-friendly as we can be, since it doesn't cost us anything.