Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge deprecated functional tests with counterpart functional test #180

Open
abmusse opened this issue Mar 25, 2020 · 2 comments
Open

Merge deprecated functional tests with counterpart functional test #180

abmusse opened this issue Mar 25, 2020 · 2 comments
Assignees
@abmusse
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Milestone
Version 1.1.0

Comments

@abmusse
Copy link
Member

abmusse commented Mar 25, 2020

We can skip tests programatically with:

image

https://mochajs.org/#inclusive-tests

With this we can move tests from tests/functional/deprecated folder into their respective test file in test/functional. Just need to add a describe block for the deprecated tests and test if idb or rest transport is being used used. If not we can just skip those deprecated tests.

Originally posted by @abmusse in #157
@abmusse abmusse changed the title Merge deprecated functional tests with counterpart functional test test Merge deprecated functional tests with counterpart functional test Mar 25, 2020
@abmusse abmusse added this to the Version 1.1 milestone Apr 7, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label May 7, 2020
@abmusse
Copy link
Member Author

abmusse commented May 14, 2020

To make this work we first need switch test cases from arrow functions. See #283

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Oct 6, 2020
@kadler kadler closed this as completed Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@abmusse abmusse self-assigned this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abmusse abmusse

Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
Version 1.1.0
Development

No branches or pull requests
2 participants
@kadler @abmusse