Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set per-test timeout values #198

Open
kadler opened this issue Mar 27, 2020 · 2 comments · May be fixed by #301
Open

Set per-test timeout values #198

kadler opened this issue Mar 27, 2020 · 2 comments · May be fixed by #301
Assignees
@abmusse
Labels
enhancement New feature or request keep-open Exempts stale action from auto closing the issue/pr.
Milestone
Version 1.1.0

Comments

@kadler
Copy link
Member

kadler commented Mar 27, 2020

We should set timeout values for each test to take in to account how long it should run, since the tests vary widely.

https://mochajs.org/#test-level
@kadler kadler added the enhancement New feature or request label Mar 27, 2020
@kadler kadler added this to the Version 1.1 milestone Mar 27, 2020
@kadler kadler mentioned this issue Mar 27, 2020
Closed
@kadler
Copy link
Member Author

kadler commented Mar 27, 2020

Blocked by #200

kadler added a commit to kadler/nodejs-itoolkit that referenced this issue Mar 27, 2020
@kadler
ci: Use 5 second timeout for slow tests
1733353 
Calling QSH can take over 3 seconds on our IBM i system running CI :(

This would be better addressed on a test-by-test basis. See IBM#198
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Apr 27, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Apr 28, 2020
@github-actions github-actions bot closed this as completed Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@abmusse abmusse linked a pull request Oct 21, 2020 that will close this issue
test: Set per-test timeout #301
Open
@abmusse abmusse self-assigned this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abmusse abmusse

Labels
enhancement New feature or request keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
Version 1.1.0
Development

Successfully merging a pull request may close this issue.

test: Set per-test timeout IBM/nodejs-itoolkit
2 participants
@kadler @abmusse