Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint fail due when using eslint-plugin-mocha #289

Open
3 of 4 tasks
kadler opened this issue Jun 10, 2020 · 1 comment · May be fixed by #304
Open
3 of 4 tasks

eslint fail due when using eslint-plugin-mocha #289

kadler opened this issue Jun 10, 2020 · 1 comment · May be fixed by #304
Assignees
@abmusse
Labels
bug Something isn't working keep-open Exempts stale action from auto closing the issue/pr.
Milestone
Version 1.1.0

Comments

@kadler
Copy link
Member

kadler commented Jun 10, 2020 •
edited by abmusse

The following Mocha eslint rules are broken by our existing tests:

These are disabled for now.
@kadler kadler added the bug Something isn't working label Jun 10, 2020
@kadler kadler added this to the Version 1.1 milestone Jun 10, 2020
kadler added a commit that referenced this issue Jun 10, 2020
@kadler
test: Use eslint-plugin-mocha for tests
63ccb9d 
This pulls in the eslint-plugin-mocha and enables its use when linting
tests. Because our existing tests do not always follow the Mocha
conventions, some mocha rules are disable for now. See #289
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Jul 12, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Jul 13, 2020
This was referenced Jul 13, 2020
Merged
Merged
@abmusse abmusse linked a pull request Jul 21, 2020 that will close this issue
Open
@github-actions github-actions bot closed this as completed Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
@abmusse abmusse self-assigned this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abmusse abmusse

Labels
bug Something isn't working keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
Version 1.1.0
Development

Successfully merging a pull request may close this issue.

test: Fix mocha/no-skipped-tests IBM/nodejs-itoolkit
2 participants
@kadler @abmusse