Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: idb transport to use bindParameters #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: idb transport to use bindParameters #307

wants to merge 1 commit into from

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 23, 2020

resolves #305

@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Aug 23, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Aug 24, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
@abmusse abmusse force-pushed the idb-transport-bindParameters branch from 36b024e to 09a9d1b Compare January 12, 2021 21:40
@abmusse abmusse force-pushed the idb-transport-bindParameters branch from 09a9d1b to 475285c Compare January 12, 2021 21:42
@abmusse abmusse marked this pull request as ready for review January 12, 2021 21:45
@abmusse
Copy link
Member Author

abmusse commented Jan 12, 2021

Ran functional tests locally since the build system is down.

$ npm run test-integration

> itoolkit@1.0.0 test-integration~/nodejs-itoolkit
> ./node_modules/mocha/bin/mocha --timeout 5s test/functional/*.js



  CommandCall Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    CL command tests
      ✓ calls CL command (220ms)
    SH command tests
      ✓ calls PASE shell command (1437ms)
    QSH command tests
      ✓ calls QSH command (2133ms)

  ProgramCall Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    addParam
      ✓ calls QWCRSVAL program checks if it ran successfully (74ms)
    addReturn
      - calls ZZVARY4 and checks the return value

  DataQueue Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    sendToDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:46:18
iDataQueue deprecated As of v1.0, 'iDataQueue.sendToDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:48:10
      ✓ sends data to specified DQ (71ms)
    receiveFromDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:60:18
iDataQueue deprecated As of v1.0, 'iDataQueue.receiveFromDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:62:10
      ✓ receives data from specfied DQ (65ms)
    clearDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:74:18
iDataQueue deprecated As of v1.0, 'iDataQueue.clearDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:76:10
      ✓ clears the specifed DQ (74ms)

  iNetwork Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getTCPIPAttr
iNetwork deprecated As of v1.0, class 'iNetwork' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:34:19
iNetwork deprecated As of v1.0, 'iNetwork.getTCPIPAttr()' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:36:11
      ✓ retrieves TCP/IP Attributes (84ms)
    getNetInterfaceData
iNetwork deprecated As of v1.0, class 'iNetwork' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:77:19
iNetwork deprecated As of v1.0, 'iNetwork.getNetInterfaceData()' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:79:11
      ✓ retrieves IPv4 network interface info (100ms)

  iObj Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    retrUsrAuth
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:33:19
iObj deprecated As of v1.0, 'iObj.retrUsrAuth()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:35:11
      ✓ returns uses's authority for an object  (75ms)
    rtrCmdInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:78:19
iObj deprecated As of v1.0, 'iObj.retrCmdInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:80:11
      ✓ returns command info (74ms)
    retrPgmInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:131:19
iObj deprecated As of v1.0, 'iObj.retrPgmInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:133:11
      ✓ returns program info (89ms)
    retrSrvPgmInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:206:19
iObj deprecated As of v1.0, 'iObj.retrSrvPgmInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:208:11
      ✓ returns service program info (140ms)
    retrUserInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:262:19
iObj deprecated As of v1.0, 'iObj.retrUserInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:264:11
      ✓ returns specified user profile info (75ms)
    retrUsrAuthToObj
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:289:19
iObj deprecated As of v1.0, 'iObj.retrUserAuthToObj()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:291:11
      ✓ retrieves info for users who are authorized to an object using idb transpsort (75ms)
    addToLibraryList
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:317:19
iObj deprecated As of v1.0, 'iObj.addToLibraryList()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:319:11
      ✓ appends lib to user's lib list (67ms)

  iProd Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getPTFInfo
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:33:20
iProd deprecated As of v1.0, 'iProd.getPTFInfo()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:35:12
      ✓ returns info for specified ptf (127ms)
    getProductInfo
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:76:20
iProd deprecated As of v1.0, 'iProd.getProductInfo()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:78:12
      ✓ returns info for specified product (70ms)
    getInstalledProducts
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:109:20
iProd deprecated As of v1.0, 'iProd.getInstalledProducts()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:111:12
      ✓ returns info for installed products (867ms)

  iSql Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    prepare & execute
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:34:19
      ✓ prepares & executes stored procedure then fetch results (316ms)
    addQuery & fetch
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:68:19
      ✓ runs a query and fetches results (218ms)
    added test to ensure issue #11 was resolved
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:94:19
      ✓ should parse SQL result set empty data tags correctly (211ms)
    tables
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:121:19
      ✓ returns meta data for specified table (206ms)
    tablePriv
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:146:19
      ✓ returns privilege data for a table (243ms)
    columns
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:173:19
      ✓ returns meta data for a column (266ms)
    columnPriv
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:211:19
      ✓ returns privilege data for a column (242ms)
    procedures
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:240:19
      ✓ returns meta data on for a procedure (208ms)
    pColumns
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:268:19
      ✓ returns meta data for procedure column (250ms)
    primaryKeys
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:307:19
      ✓ returns meta data for a primary key (212ms)
    foreignKeys
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:333:19
      ✓ returns meta data for a foreign key (227ms)
    statistics
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:368:19
      ✓ returns stats info for table (463ms)
    special
      - returns meta data for special columns
    rowCount
      - returns the number of rows affected by statement

  UserSpace Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    createUserSpace
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:51:25
iUserSpace deprecated As of v1.0, 'iUserSpace.createUserSpace()' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:57:17
      ✓ creates a user space (93ms)
    setUserSpaceData
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:75:25
iUserSpace deprecated As of v1.0, 'iUserSpace.setUserSpaceData()' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:79:17
      ✓ sets data within the user space (81ms)
    getUserSpaceData
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:96:25
iUserSpace deprecated As of v1.0, 'iUserSpace.getUserSpaceData()' is deprecated ad will be removed at a later time. test/functional/iUserSpaceFunctional.js:98:17
      ✓ returns specified length of data (75ms)
    deleteUserSpace
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:113:25
iUserSpace deprecated As of v1.0, 'iUserSpace.deleteUserSpace()' is deprecated and will be removed at a later time test/functional/iUserSpaceFunctional.js:115:17
      ✓ removes a user space (77ms)

  iWork Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getSysValue
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:34:20
iWork deprecated As of v1.0, 'iWork.getSysValue()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:36:12
      ✓ returns the value of system variable (68ms)
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:46:20
iWork deprecated As of v1.0, 'iWork.getSysValue()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:48:12
      ✓ returns an error when the specified system value is invalid
    getSysStatus
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:58:20
iWork deprecated As of v1.0, 'iWork.getSysStatus()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:60:12
      ✓ returns basic system status information about the signed-on users and batch jobs (88ms)
    getSysStatusExt
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:88:20
iWork deprecated As of v1.0, 'iWork.getSysStatusExt()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:90:12
      ✓ returns more detailed system status info (1163ms)
    getJobStatus
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:133:20
iWork deprecated As of v1.0, 'iWork.getJobStatus()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:135:12
      ✓ returns status of specified job (72ms)
    getJobInfo
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:149:20
iWork deprecated As of v1.0, 'iWork.getJobInfo()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:151:12
      ✓ returns info on specfed job (73ms)
    getDataArea
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:200:22
iWork deprecated As of v1.0, 'iWork.getDataArea()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:202:14
      ✓ returns contents of a data area (130ms)


  42 passing (11s)
  3 pending

@abmusse abmusse requested a review from kadler January 12, 2021 22:01
kadler
kadler approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abmusse abmusse added this to the Version 1.1 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
Version 1.1.0
Development

Successfully merging this pull request may close these issues.

Update idb transport to use bindParameters
2 participants
@abmusse @kadler