Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for new error handling #311

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: add support for new error handling #311

merged 1 commit into from
Mar 22, 2024

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Mar 20, 2024

PR summary

This PR includes the changes needed to support the new Go SDK error handling feature.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Mar 20, 2024
@padamstx padamstx requested a review from dpopp07 March 20, 2024 23:43
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the latest go core once it comes out but otherwise, looks good!

go.mod Outdated
@@ -3,7 +3,7 @@ module github.com/IBM/platform-services-go-sdk
go 1.20

require (
github.com/IBM/go-sdk-core/v5 v5.15.3
github.com/IBM/go-sdk-core/v5 v5.16.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.16.3 should be out soon - would be good to use that once it is.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx merged commit 5beb5c4 into main Mar 22, 2024
4 checks passed
@padamstx padamstx deleted the new-error-support branch March 22, 2024 17:51
ibm-devx-sdk pushed a commit that referenced this pull request Mar 22, 2024
## [0.61.3](v0.61.2...v0.61.3) (2024-03-22)

### Bug Fixes

* add support for new error handling ([#311](#311)) ([5beb5c4](5beb5c4))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.61.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants