fix(Enterprise Management): add options property to create_account payload #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt payload Signed-off-by: namratabhadauriya <namrata.nitw@gmail.com>
padamstx
changed the title
|
Please post evidence that the integration tests and examples code ran clean with your changes. |
padamstx
requested changes
Mar 25, 2024
| @@ -43,7 +43,7 @@ type EnterpriseManagementV1 struct { | |||
| } | |||
|
|
|||
| // DefaultServiceURL is the default URL to make service requests to. | |||
| const DefaultServiceURL = "https://enterprise.cloud.ibm.com/v1" | |||
| const DefaultServiceURL = "https://enterprise.test.cloud.ibm.com/v1" | |||
There was a problem hiding this comment.
This is incorrect. The default service URL for the service should be the production endpoint, not the staging endpoing. It looks like you used the staging/test version of the API definition when generating the SDK code. You should use the production version of the API instead.
namratabhadauriya
force-pushed
the
update-enterprise_management
branch
from
5913782
to
046801a
Compare
|
. |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 25, 2024
## [0.61.4](v0.61.3...v0.61.4) (2024-03-25) ### Bug Fixes * **Enterprise Management:** add options property to create_account payload ([#313](#313)) ([4d1bbc4](4d1bbc4))
|
🎉 This PR is included in version 0.61.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
added options field in create child account in enterprise payload.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information