Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ATracker): remove endpoint field from Cloudlogs_endpoint #318

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(ATracker): remove endpoint field from Cloudlogs_endpoint #318

merged 1 commit into from
Apr 10, 2024

Conversation

veenanr
Copy link
Contributor

@veenanr veenanr commented Apr 9, 2024

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

/Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk
veenas-mbp:platform-services-go-sdk veenarao$ cd atrackerv2
veenas-mbp:atrackerv2 veenarao$ go test
Running Suite: AtrackerV2 Suite
===============================
Random Seed: 1712687147
Will run 94 of 94 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 94 of 94 Specs in 3.962 seconds
SUCCESS! -- 94 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv2	5.019s
veenas-mbp:atrackerv2 veenarao$ go test github.com/IBM/platform-services-go-sdk/atrackerv2 -tags="integration" -v
=== RUN   TestAtrackerV2
Running Suite: AtrackerV2 Suite
===============================
Random Seed: 1712687176
Will run 137 of 137 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
------------------------------
• [SLOW TEST:6.337 seconds]
AtrackerV2 Integration Tests
/Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk/atrackerv2/atracker_v2_integration_test.go:43
  DeleteTarget - Delete a target
  /Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk/atrackerv2/atracker_v2_integration_test.go:757
    DeleteTarget(deleteTargetOptions *DeleteTargetOptions)
    /Users/veenarao/go/src/github.com/IBM/platform-services-go-sdk/atrackerv2/atracker_v2_integration_test.go:805
------------------------------

Ran 137 of 137 Specs in 20.301 seconds
SUCCESS! -- 137 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAtrackerV2 (20.35s)
PASS
ok  	github.com/IBM/platform-services-go-sdk/atrackerv2	21.364s

@veenanr
fix (ATracker): Removed endpoint field from Cloudlogs_endpoint
8275e9f 
Signed-off-by: Veena Rao <veenar@us.ibm.com>
@veenanr veenanr requested a review from padamstx April 9, 2024 18:43
@padamstx padamstx changed the title fix (ATracker): Removed endpoint field from Cloudlogs_endpoint fix(ATracker): remove endpoint field from Cloudlogs_endpoint Apr 10, 2024
@padamstx padamstx self-assigned this Apr 10, 2024
padamstx
padamstx approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 51b4afc into main Apr 10, 2024
4 checks passed
@padamstx padamstx deleted the regen-atracker-04092024 branch April 10, 2024 18:21
ibm-devx-sdk pushed a commit that referenced this pull request Apr 10, 2024
@semantic-release-bot
chore(release): 0.62.3 release notes [skip ci]
2020bc2 
## [0.62.3](v0.62.2...v0.62.3) (2024-04-10)

### Bug Fixes

* **ATracker:** remove endpoint field from CloudlogsEndpoint ([#318](#318)) ([51b4afc](51b4afc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.62.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veenanr @ibm-devx-sdk @padamstx