Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Usage Reports): re-add offset to SnapshotListNext #324

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

Jdatechong
Copy link
Contributor

PR summary

re-add the offset property to SnapshotListNext which was incorrectly removed after re-generating the service

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SnapshotListNext should now contain the offset property

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

test results:

Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1714067348
Will run 103 of 103 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 103 of 103 Specs in 3.204 seconds
SUCCESS! -- 103 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  3.852s

integration tests:

Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1714067407
Will run 119 of 119 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 119 of 119 Specs in 18.440 seconds
SUCCESS! -- 119 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  19.778s

examples:

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 117 of 117 Specs in 14.238 seconds
SUCCESS! -- 117 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  15.493s

Signed-off-by: Jonathan Date-Chong <jtdatechong@gmail.com>
@padamstx padamstx self-assigned this Apr 25, 2024
@padamstx padamstx self-requested a review April 25, 2024 20:59
Signed-off-by: Jonathan Date-Chong <jtdatechong@gmail.com>
@Jdatechong
Copy link
Contributor Author

test results after re-generating:

$  go test
Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1714153741
Will run 109 of 109 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 109 of 109 Specs in 3.493 seconds
SUCCESS! -- 109 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  4.760s
$ go test -tags=integration
Running Suite: UsageReportsV4 Suite
===================================
Random Seed: 1714153762
Will run 125 of 125 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 125 of 125 Specs in 23.507 seconds
SUCCESS! -- 125 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  24.620s

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
The changes include a new operation and we'll need an integration test and working examples code for that at some point in the near future (I won't hold up this PR for that).

@padamstx padamstx merged commit 7323d29 into IBM:main Apr 26, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Apr 26, 2024
## [0.62.10](v0.62.9...v0.62.10) (2024-04-26)

### Bug Fixes

* **Usage Reports:** re-add offset to SnapshotListNext ([#324](#324)) ([7323d29](7323d29))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.62.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants