Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping the donation_account column from the inventory group #7413

Closed
jniles opened this issue Jan 10, 2024 · 0 comments · Fixed by #7589
Closed

Consider dropping the donation_account column from the inventory group #7413

jniles opened this issue Jan 10, 2024 · 0 comments · Fixed by #7589
Labels
proposal

Comments

@jniles
Copy link
Contributor

jniles commented Jan 10, 2024

Since the inception of BHIMA, we have never used the donation_account in the inventory group. No module depends on it, not Javascript code references it.

I propose we remove it entirely, unless there is a plan to use it. Considering it hasn't been used to date, I cannot imagine a scenario when we would use it.
jniles added a commit to Third-Culture-Software/bhima that referenced this issue May 21, 2024
@jniles
chore: rm donation_account
329cf2b 
Removes vestigial code referencing the donation_account.  This has no
impact on user-facing experience as the client-side code had been
removed some time ago.  On the server side, it simply removes the code
related to donation accounts.

Closes IMA-WorldHealth#7413.
@jniles jniles mentioned this issue May 21, 2024
Closed
jniles added a commit to Third-Culture-Software/bhima that referenced this issue May 23, 2024
@jniles
chore: rm donation_account
8cbd259 
Removes vestigial code referencing the donation_account.  This has no
impact on user-facing experience as the client-side code had been
removed some time ago.  On the server side, it simply removes the code
related to donation accounts.

Closes IMA-WorldHealth#7413.
@jniles jniles mentioned this issue May 23, 2024
Merged
jniles added a commit to Third-Culture-Software/bhima that referenced this issue May 24, 2024
@jniles
chore: rm donation_account
7ed8550 
Removes vestigial code referencing the donation_account.  This has no
impact on user-facing experience as the client-side code had been
removed some time ago.  On the server side, it simply removes the code
related to donation accounts.

Closes IMA-WorldHealth#7413.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
No milestone
1 participant
@jniles