Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information for debugging #21

Closed
cintek opened this issue Feb 28, 2024 · 4 comments
Closed

More information for debugging #21

cintek opened this issue Feb 28, 2024 · 4 comments
Assignees

Comments

@cintek
Copy link
Contributor

cintek commented Feb 28, 2024

To make debugging easier we should show some build information in the client. Therefore, we want to show a build number of the client (#19) and the backend (#20) in the client. One possible place to do so would be an "About" section in the configuration menu of the client.

@ThomasJunk ThomasJunk self-assigned this Mar 7, 2024
@ThomasJunk
Copy link
Contributor

Commit f8fbac2 has a basic version of this.

@bernhardreiter bernhardreiter assigned koplas and unassigned ThomasJunk Apr 2, 2024
@bernhardreiter
Copy link
Contributor

@koplas for the backend and the version number:

https://tip.golang.org/doc/go1.18#go-version says that go now embeds some info, is worth trying out, the problem is just that git describe does not deliver a correct Semver re-release version number. So the solution in the Makefile of csaf_distribution still seems cool for the backend. We could add and display the new go build information additionally.

@koplas
Copy link
Contributor

koplas commented Apr 3, 2024

@koplas for the backend and the version number:

https://tip.golang.org/doc/go1.18#go-version says that go now embeds some info, is worth trying out, the problem is just that git describe does not deliver a correct Semver re-release version number. So the solution in the Makefile of csaf_distribution still seems cool for the backend. We could add and display the new go build information additionally.

Currently go only includes useful version information on go install or go get and not go build. For more info see golang/go#50603.
As a workaround, the version information can be overwritten with:

go build -ldflags "-X main.version=v0.1.0" ....

If the issue is fixed the flag can be removed, without changing the code.

@koplas
Copy link
Contributor

koplas commented Apr 29, 2024

This is completed with: 715d613.

@koplas koplas closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants