Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Browser-sync #24

Open
pawelmiklas opened this issue Oct 2, 2018 · 3 comments
Open

Browser-sync #24

pawelmiklas opened this issue Oct 2, 2018 · 3 comments

Comments

@pawelmiklas
Copy link

Browser-sync on html is not working. On sass files is okey.

@skaltenegger
Copy link

skaltenegger commented Dec 11, 2018

@IamManchanda great work! Is there any way you could take a look at this issue - would make this package so much better!

Ps.: https://github.com/IamManchanda/gulp-webpack/blob/master/gulpfile.js#L211 might have a small typo and should be gulp.watch(srcPath('html', true)) - am I right?

Super glad to hear your feedback!
Best, Stefan

@skaltenegger
Copy link

skaltenegger commented Dec 11, 2018

@snaqu in case you need a quick fix: The change from my answer above plus the following change (inserting another browserSync.reload)

// Watch - Markup
    gulp.watch(srcPath("html"), true).on(
      "all",
      gulp.series(
        Object.assign(cleanMarkup(mode), {
          displayName: `Watching Markup Task: Clean - ${modeName}`
        }),
        Object.assign(buildMarkup(mode), {
          displayName: `Watching Markup Task: Build - ${modeName}`
        }),
        browserSync.reload // INSERTED
      ),
      browserSync.reload
    );

did the job for me - hope that helps!

@IamManchanda
Copy link
Owner

Thanks a lot guys!
Sorry I had no idea that this project got love ... will surely dig next weekend

Thanks for your feedback ... will look into these!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants