Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Prettier version 3 #109

Closed
tvanantwerp opened this issue Jul 10, 2023 · 7 comments · Fixed by #111
Closed

Support for Prettier version 3 #109

tvanantwerp opened this issue Jul 10, 2023 · 7 comments · Fixed by #111
Assignees

Comments

@tvanantwerp
Copy link

Is your feature request related to a problem?
Cannot currently be used with version 3 of Prettier

npm i -D @ianvs/prettier-plugin-sort-imports
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: stripe-connect-app-embed@1.0.0
npm ERR! Found: prettier@3.0.0
npm ERR! node_modules/prettier
npm ERR!   dev prettier@"^3.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer prettier@"2.x" from @ianvs/prettier-plugin-sort-imports@4.0.2
npm ERR! node_modules/@ianvs/prettier-plugin-sort-imports
npm ERR!   dev @ianvs/prettier-plugin-sort-imports@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/tvanantwerp/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/tvanantwerp/.npm/_logs/2023-07-10T15_00_10_576Z-debug-0.log

Describe the solution you'd like
Support for version 3 of Prettier.

Related issue in @trivago/prettier-plugin-sort-imports

@IanVS
Copy link
Owner

IanVS commented Jul 10, 2023

Thanks, I believe we actually do work with version 3, just haven't bumped the peer dependency range. Would you be willing to try installing with --legacy-peer-deps, and check that the plugin works correctly? And if so, maybe you can submit a PR that updates our peer dependency range? Thanks!

@Sparticuz
Copy link
Contributor

Sparticuz commented Jul 10, 2023

Seems to work for me.

EDIT: I mean, after I installed it with --legacy-peer-deps

@basselworkforce
Copy link

basselworkforce commented Jul 10, 2023

@IanVS I submitted a PR, not sure if you got a chance to see it

@IanVS
Copy link
Owner

IanVS commented Jul 10, 2023

Thanks, but that is the trivago plugin, which I do not have any control over. I don't know if the Trivago version is compatible with Prettier 3 or not.

@basselworkforce
Copy link

Ah sorry my mistake, thanks

@fbartho
Copy link
Collaborator

fbartho commented Jul 10, 2023

@basselworkforce if you're motivated, could you possibly test this PR? #75

I think we're ready for prettier3 with that PR!

@basselworkforce
Copy link

@basselworkforce if you're motivated, could you possibly test this PR? #75

I think we're ready for prettier3 with that PR!

sorry for the confusion I don't actually use this version, I use the trivago one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants