Feature: `importOrderCombineTypeAndValueImports` #20

fbartho · 2022-05-18T20:53:24Z

Fixes: #4

Allows the ability for users to convert import type expressions into import {type …} expressions via a boolean flag.

Should this be controlled via a string parameter?

Just use javascript or js

Fixes: #4 Allows the ability for users to convert `import type` expressions into `import {type …}` expressions via a boolean flag. Should this be controlled via a string parameter?

IanVS · 2022-05-18T21:08:29Z

I think we need to talk about whether this warrants yet another option, but in the meantime, do you think you could add some tests? You might be able to use the test cases from my codemod as a starting point: https://github.com/IanVS/type-import-codemod/blob/9f3210861a77216f07317537a04ce61467e0df7e/src/transform.test.ts

fbartho · 2022-05-18T21:12:35Z

Happy to add those tests. I do tend to have macro-tests that assert a ton of functionality all at once. Not sure that's a good sign, but code-coverage likes it 😉

https://github.com/IanVS/type-import-codemod/blob/9f3210861a77216f07317537a04ce61467e0df7e/src/transform.test.ts

fbartho · 2022-05-18T21:36:18Z

@IanVS Test cases imported, the only differences I can see

this plugin sorts the output by source, while the codemod didn't
this the codemod grouped type imports together, while this plugin just sorts all the fields by name.

Do we need/want to group type imports when sorting?

…ts-with-regular-imports

Try to improve the naming and docs for the parameters, particularly the nodes vs importNodes distinciton

…re stale!

…ts-with-regular-imports

IanVS · 2022-06-09T20:22:00Z

Sorry, it looks like there are a number of conflicts on this PR now. Your best bet might be to reset hard to main, and then cherry-pick the commits from this PR back onto the branch.

# Conflicts: # README.md # src/index.ts # src/preprocessor.ts # src/types.ts # src/utils/__tests__/get-all-comments-from-nodes.spec.ts # src/utils/__tests__/get-code-from-ast.spec.ts # src/utils/__tests__/get-sorted-nodes-by-import-order.spec.ts # src/utils/__tests__/get-sorted-nodes.spec.ts # src/utils/__tests__/merge-nodes-with-matching-flavors.spec.ts # src/utils/__tests__/remove-nodes-from-original-code.spec.ts # src/utils/get-sorted-nodes.ts # src/utils/merge-nodes-with-matching-flavors.ts

fbartho · 2022-06-15T23:13:52Z

@IanVS sorry about the lag re: updates, I was under the weather last week! main is now merged in. Most conflicts were trivially solved with a 3-headed merge (using p4merge), and the few that weren't automatically solved don't seem too bad.

Please take another look, and let me know if this can proceed.

IanVS

It took me a while to get to this, sorry about that. I think it mostly looks good. I had a few small comments/questions.

Unless you or @blutorange feels strongly, I'd like to sort the type imports to the end. I think it looks better that way, and is more readable. Would you mind making that change? Then we can merge and release this, and prepare for the breaking changes release.

IanVS · 2022-07-08T03:06:13Z

src/preprocessor.ts

+        !importOrderMergeDuplicateImports
+    ) {
+        console.warn(
+            "[@ianvs/prettier-plugin-sort-imports]: Option combination of both importOrderMergeTypeImportsIntoRegular: true and importOrderMergeDuplicateImports: false is not won't do anything!",


Suggested change

"[@ianvs/prettier-plugin-sort-imports]: Option combination of both importOrderMergeTypeImportsIntoRegular: true and importOrderMergeDuplicateImports: false is not won't do anything!",

"[@ianvs/prettier-plugin-sort-imports]: Enabling importOrderMergeTypeImportsIntoRegular will have no effect unless importOrderMergeDuplicateImports is also enabled.",

IanVS · 2022-07-08T03:56:12Z

src/utils/merge-nodes-with-matching-flavors.ts

 function nodeIsImportNamespaceSpecifier(
    node: ImportSpecifier | ImportDefaultSpecifier | ImportNamespaceSpecifier,
 ): node is ImportNamespaceSpecifier {
    return node.type === 'ImportNamespaceSpecifier';
 }
-
-/** import Default from "someModule" */


Why remove the comments?

IanVS · 2022-07-08T04:07:28Z

src/utils/merge-nodes-with-matching-flavors.ts

+    return node.type === 'ImportSpecifier';
+}
+
+function convertImportSpecifierType(node: ImportSpecifier) {


Can we call this convertImportSpecifierToType?

IanVS · 2022-07-25T15:17:58Z

Hi @fbartho. How would you like to proceed on this one? We can merge it as-is if you don't have time to make changes, and I can play around with re-ordering the type/value import specifiers in a separate PR.

fbartho · 2022-07-25T17:47:22Z

Hiya! I was traveling 2 weeks ago, and totally missed these messages!

No objections to the changes, I’m happy to make them — should be able to get to them this week or this coming Saturday

IanVS · 2022-07-25T17:50:19Z

Great, thanks! I hope you had a good time on your travels!

IanVS · 2022-08-17T15:29:52Z

Hi @fbartho just checking in to see if this is still something you'll be able to get to. NBD if not, just was wondering.

fbartho · 2022-09-07T17:24:11Z

@IanVS whoops! It's been a little bit of a scramble. I'll take a look at this, this week!

IanVS · 2022-10-24T12:44:15Z

Thanks for your work on this @fbartho! I pushed up a few tweaks, and am going to merge / release. We can continue to iterate, but I'd like to start preparing for a breaking release, to include prettier 3 support.

fbartho added 6 commits May 18, 2022 12:26

Add TypeScript enforcement to not-forgetting our Options schema!

d4df2f0

Change syntax of getCodeFromAst to allow for node deletion

cf4e6af

Github-linguist doesn't understand ecmascript 6

f03f96b

Just use javascript or js

Feature: importOrderMergeDuplicateImports - Fixes #4

6c47166

Merge branch 'main' into fb/simplify-import-duplicates

dc43318

Feature: importOrderMergeTypeImportsIntoRegular

a62bcd1

Fixes: #4 Allows the ability for users to convert `import type` expressions into `import {type …}` expressions via a boolean flag. Should this be controlled via a string parameter?

fbartho requested review from blutorange and IanVS May 18, 2022 20:53

fbartho mentioned this pull request May 18, 2022

[Feature] Combine type and value imports #4

Closed

fbartho added 2 commits May 18, 2022 14:33

merge-tests: extract defaultOptions

db923e7

merge-imports: Add test cases from codemod

e2ab51d

https://github.com/IanVS/type-import-codemod/blob/9f3210861a77216f07317537a04ce61467e0df7e/src/transform.test.ts

This was referenced May 19, 2022

Feature: importOrderMergeDuplicateImports #19

Merged

New major version -- what do we want to change #22

Closed

fbartho added 3 commits May 19, 2022 12:57

switch from toMatchInlineSnapshot to toEqual

9ef2abe

Merge branch 'fb/simplify-import-duplicates' into fb/merge-type-impor…

61f7797

…ts-with-regular-imports

switch from toMatchInlineSnapshot to toEqual

8edeb51

fbartho mentioned this pull request May 19, 2022

Feature: group type-imports when sorting Identifiers #25

Closed

3 tasks

fbartho added 10 commits May 19, 2022 20:49

PR Feedback: rename regular imports to value imports

f5f9e26

PR Feedback: Readme wording

42999c9

PR Feedback: rename getCodeFromAst parameters

2fe3128

Try to improve the naming and docs for the parameters, particularly the nodes vs importNodes distinciton

PR Feedback: import-flavor @returns documentation

e393e5e

PR Feedback: hoist hasIgnoreNextNode for reuse

e569488

PR Feedback: Add strong types for ChunkType/FlavorType

0e3a871

PR Feedback: deleteContext -> nodesToDelete

d0a2692

PR Feedback: comment-update: once you mutate nodes, lines/locations a…

6cb7764

…re stale!

Merge branch 'fb/simplify-import-duplicates' into fb/merge-type-impor…

3c3c142

…ts-with-regular-imports

PR Feedback: apply getCodeFromAst renames

99b6716

Base automatically changed from fb/simplify-import-duplicates to main June 9, 2022 20:20

IanVS reviewed Jul 8, 2022

View reviewed changes

IanVS mentioned this pull request Sep 29, 2022

Compatibility with Prettier 3.0 #37

Closed

IanVS added 4 commits October 23, 2022 22:04

Minor review comments

03b9926

Group type imports after value in importOrderSortSpecifiers

beb9066

Rename option for clarity

75b11fe

Add TOC to readme, re-arrange a bit

a5e4f6b

IanVS merged commit b7c8ca5 into main Oct 24, 2022

IanVS deleted the fb/merge-type-imports-with-regular-imports branch October 24, 2022 12:44

IanVS changed the title ~~Feature: importOrderMergeTypeImportsIntoRegular~~ Feature: importOrderCombineTypeAndValueImports Oct 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: `importOrderCombineTypeAndValueImports` #20

Feature: `importOrderCombineTypeAndValueImports` #20

fbartho commented May 18, 2022

IanVS commented May 18, 2022

fbartho commented May 18, 2022

fbartho commented May 18, 2022

IanVS commented Jun 9, 2022

fbartho commented Jun 15, 2022

IanVS left a comment

IanVS Jul 8, 2022

IanVS Jul 8, 2022

IanVS Jul 8, 2022

IanVS commented Jul 25, 2022

fbartho commented Jul 25, 2022

IanVS commented Jul 25, 2022

IanVS commented Aug 17, 2022

fbartho commented Sep 7, 2022

IanVS commented Oct 24, 2022

	"[@ianvs/prettier-plugin-sort-imports]: Option combination of both importOrderMergeTypeImportsIntoRegular: true and importOrderMergeDuplicateImports: false is not won't do anything!",
	"[@ianvs/prettier-plugin-sort-imports]: Enabling importOrderMergeTypeImportsIntoRegular will have no effect unless importOrderMergeDuplicateImports is also enabled.",

Feature: importOrderCombineTypeAndValueImports #20

Feature: importOrderCombineTypeAndValueImports #20

Conversation

fbartho commented May 18, 2022

IanVS commented May 18, 2022

fbartho commented May 18, 2022

fbartho commented May 18, 2022

IanVS commented Jun 9, 2022

fbartho commented Jun 15, 2022

IanVS left a comment

Choose a reason for hiding this comment

IanVS Jul 8, 2022

Choose a reason for hiding this comment

IanVS Jul 8, 2022

Choose a reason for hiding this comment

IanVS Jul 8, 2022

Choose a reason for hiding this comment

IanVS commented Jul 25, 2022

fbartho commented Jul 25, 2022

IanVS commented Jul 25, 2022

IanVS commented Aug 17, 2022

fbartho commented Sep 7, 2022

IanVS commented Oct 24, 2022

Feature: `importOrderCombineTypeAndValueImports` #20

Feature: `importOrderCombineTypeAndValueImports` #20