Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers from different sources aren't treated equally #122

Open
Fishbowler opened this issue Jun 23, 2018 · 1 comment
Open

Headers from different sources aren't treated equally #122

Fishbowler opened this issue Jun 23, 2018 · 1 comment

Comments

@Fishbowler
Copy link
Collaborator

Headers added via addHeader or via request settings in config() are case-normalised.
Headers added via request params aren't.

That this is possible isn't actually documented - and it looks like all request params are supported.

This leads to a larger question:
Should we keep consistency (so in this case, move all normalisation to this block, perhaps), or do we respect the original intent of the developer?

@Fishbowler
Copy link
Collaborator Author

Here's where the config() headers get routed through addHeader so that they're case normalised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant