-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are hard to debug #126
Comments
Sounds good to me! It seems like we should also remove mock_request which is deprecated, and replace everything with nock. Does that make sense? |
Also! If we switch over to using promises and promise-based tests, we should be able to make our test setup should easier to reason about. Instead of |
Started work on this. |
I'm convinced adding this |
There are a variety of nock'd domains.
When HTTP_PROXY is set to debug the real httpbin tests, it takes all nock traffic too, and requires a lot of configuration of NO_PROXY (or just some faith in the tests that don't complete) that things are working.
Move all nock'd domains to a single host for easier configuration in a development environment.
The text was updated successfully, but these errors were encountered: