Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Icon component #14

Open
joeyfigaro opened this issue Sep 8, 2020 · 2 comments
Open

Provide Icon component #14

joeyfigaro opened this issue Sep 8, 2020 · 2 comments

Comments

@joeyfigaro
Copy link

It'd be great if there were an Icon component that used a name prop to render the appropriate icon. I'm using react-native-paper in a current project and the best way to override the icon library they're using is to provide a function that returns a single component that represents/provides access to the entire set of icons.

@tarunmangukiya
Copy link
Contributor

Hi @joeyfigaro,

Thank you for your suggestion. I think we can do it.

Actually this library is been derived from our react-unicons package, and in that, we are more concerned about bundle size. Also, I think you can use it by importing full package: https://github.com/Iconscout/react-native-unicons#usage-as-full-package. What are your views wrt Bundle Size and Full Package usage?

I am open for your suggestions. 👍

@joeyfigaro
Copy link
Author

@tarunmangukiya Thanks for the quick reply! I apologize for being so late to the party. I personally don't have any concerns of impact on bundle size for the project that brought me here—not for icons, anyway. It's at a point where we're painting with pretty broad strokes and will end up shaving down resources down the road.

From personal experience with icon libraries and react native, I'd much rather have an entire library available to me while in the height of development so I can forget about dealing with asset configuration after I do initial setup. Asset optimization for me ends up becoming part of my focus after the application is being tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants