Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: consider C++ objects instread of SWIG tuples for some data types #154

Open
spectranaut opened this issue Mar 22, 2024 · 1 comment

Comments

@spectranaut
Copy link
Contributor

Per Joanie's comment here, tuples are weird in nodejs:

> component.get_size()
_exports_AtspiPairIntInt { second: 2098, first: 3840 }

On the otherhand, they work great in python, return a python tuple as expect.

On the third hand, the underlying API does return an AtspiPosition object with an x and y attribute: https://github.com/Igalia/AXAccess/blob/c93a2928aa20513e25f507bb012d01e2de175f3b/lib/atspi/atspi_component_interface.cc#L32

Alice has taken the approach of wrapping these kinds of object for AXAPI in a custom object, which is pretty nice. See the Point object here: https://github.com/Igalia/AXAccess/pull/139/files#diff-a0cddcd5866fbc93cafe36a4b8e67f580a47c0da4d6504dc999b4633785fd40a

@spectranaut
Copy link
Contributor Author

Doing this is not a requirement for v.0, but it might be a nice direction to go in ultimately, I'd like your thoughts @joanmarie :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants