Fixing issues I had when trying to build on Windows #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm Alice I can't build with these changes, I get the following error: Before I dig into it -- are you using ninja, by any chance, when on Windows? Or are you just using the msbuild compiler? I switch to ninja at some point and wrote about it in the README, see the "important" here: https://github.com/Igalia/acacia?tab=readme-ov-file#dependencies-1 It's a pain to get the cmake to support both multi configuration generators and single configuration generators, thus the switch to ninja. |
|
Ohhh yeah I missed that :( Sorry for the noise. Geez, Windows is touchy. |
|
Just want to confirm you can build with windows and ninja's before abandoning this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIN_OUTPUT_DIRECTORYchange is because some thing were ending up inbuild/binand some things were ending up inbuild/bin/Release, but they all need to be in the same directory. This ensures that the VS Code generator doesn't get creative with adding/Releaseon the end of things.OUTFILE_DIRfor the Python SWIG target is just because it was weird seeingacacia_ia2PYTHON_wrap.cxxend up inbuild/bin- I came across that while trying to fix the above actual problemcmake copycommand out into its own step is because it wasn't running when it was part of theacacia_ia2.nodecustom command, and I couldn't figure out why, but this worked.binding.gyp.inis a temporary fix for a related problem -iaccessible2.libends up inbuild/third_party/ia2/lib/Releasefor a Release build, because Visual Studio just tacksReleaseon the end. Obviously this fix won't work for a Debug build, but we're assumingReleaseelsewhere already, so we can fix them all at the same time whenever we fix Add a Debug build configuration #178.