New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clean-up] Remove redundant platform safe-guards in core #664

Open

psaavedra opened this issue Nov 16, 2023 · 0 comments

Assignees

Labels

Member

psaavedra commented Nov 16, 2023 •

edited

Now, in https://github.com/Igalia/cog/blob/master/core/cog-view.c#L149 and in (future master)

cog/core/cog-viewport.c

Line 74 in c0774f6

if (platform) {

, we can safely assume that cog_platform_get() will always return a valid instance because we have CogFallbackPlatform always built into libcogcore.

Also address this trivial verification:
https://github.com/Igalia/cog/pull/662/files/c0774f656c7d73db285297f9d1901c8b8ced2d0a#r1395788191

Related to this comment: https://github.com/Igalia/cog/pull/662/files/c0774f656c7d73db285297f9d1901c8b8ced2d0a#r1395785705

psaavedra mentioned this issue

Allow custom viewport implementations #662

Merged

aperezdc self-assigned this

aperezdc added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment