Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete task service should not require the date field #529

Open
jaragunde opened this issue Oct 18, 2021 · 1 comment
Open

Delete task service should not require the date field #529

jaragunde opened this issue Oct 18, 2021 · 1 comment
Labels
component: backend component: web services use case: tasks wont fix Issue that is now moot due to rewrite of application

Comments

@jaragunde
Copy link
Member

Similarly to #487, when you try to delete a task via API and you don't send the date field, you will get an error. It shouldn't be necessary to send the date for this operation:

[18-Oct-2021 11:28:54 UTC] PHP Fatal error:  Uncaught TypeError: Argument 1 passed to PostgreSQLConfigDAO::isWriteAllowedForDate() must be an instance of DateTime, null given, called in /var/www/html/phpreport/model/facade/action/DeleteReportAction.php on line 76 and defined in /var/www/html/phpreport/model/dao/ConfigDAO/PostgreSQLConfigDAO.php:76
Stack trace:
#0 /var/www/html/phpreport/model/facade/action/DeleteReportAction.php(76): PostgreSQLConfigDAO->isWriteAllowedForDate(NULL)
#1 /var/www/html/phpreport/model/facade/action/Action.php(112): DeleteReportAction->doExecute()
#2 /var/www/html/phpreport/model/facade/TasksFacade.php(108): Action->execute()
#3 /var/www/html/phpreport/model/facade/TasksFacade.php(122): TasksFacade::DeleteReport(Object(TaskVO))
#4 /var/www/html/phpreport/web/services/deleteTasksService.php(131): TasksFacade::DeleteReports(Array)
#5 {main}
  thrown in /var/www/html/phpreport/model/dao/ConfigDAO/PostgreSQLConfigDAO.php on line 76
@dmtrek14 dmtrek14 added the wont fix Issue that is now moot due to rewrite of application label Sep 1, 2023
@dmtrek14
Copy link
Collaborator

dmtrek14 commented Sep 1, 2023

We are in the process of rewriting the frontend for tasks. Any outstanding bugs and enhancements for the old interface will be taken into account as we implement the new design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: backend component: web services use case: tasks wont fix Issue that is now moot due to rewrite of application
Projects
None yet
Development

No branches or pull requests

2 participants